Looks like converting the header actions to a new actions element broke the special handling in preprocess.

CommentFileSizeAuthor
#4 fix_display_of_header-2903243-4.patch3.05 KBBerdir
#4 fix_display_of_header-2903243-4-test-only.patch1.45 KBBerdir
#2 fix_display_of_header-2903243-2.patch1.61 KBBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir created an issue. See original summary.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Active » Needs review
FileSize
fix_display_of_header-2903243-2.patch1.61 KB

We no longer consistently set a class and the type is not always the type it now checks for.

Set a custom property instead, also removing the bogus loop.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Test is a bit tricky, but we could try to count table rows when adding one paragraph, but we need to also set the flag to force drag and drop to be visible.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
FileSize
fix_display_of_header-2903243-4-test-only.patch1.45 KB
fix_display_of_header-2903243-4.patch3.05 KB

The last submitted patch, 4: fix_display_of_header-2903243-4-test-only.patch, failed testing. View results

miro_dietiker credited miro_dietiker.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Fixed

Awesome, thx :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.