Message without any user [#2903143]

Although this should be an edge case, in our current project we get a WSOD on the /admin/content/message page because some of the users that created a message are deleted from the database, maybe as a result of syncing databases over different server in our OTAP.

The generated error is:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function label() on null in Drupal\message\MessageListBuilder->buildRow() (line 93 of modules/contrib/message/src/MessageListBuilder.php).

I will include a patch that resolves the issue, but maybe this error should not occur in 'normal' situations.

Comment	File	Size	Author
#2	deleted-author-name-2903143-D8.patch	573 bytes	louisnagtegaal
#2	7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

18 August 2017 at 13:23

louisnagtegaal created an issue. See original summary.

Comment #2

louisnagtegaal CreditAttribution: louisnagtegaal commented 18 August 2017 at 13:27

File	Size
deleted-author-name-2903143-D8.patch	573 bytes
7.x-1.x: PHP 5.3 & MySQL 5.5, D7 Patch Failed to Apply

Added patch.

Comment #3

louisnagtegaal CreditAttribution: louisnagtegaal commented 18 August 2017 at 13:41

Issue summary:

View changes

Comment #4

louisnagtegaal CreditAttribution: louisnagtegaal commented 18 August 2017 at 13:41

Issue summary:

View changes

Comment #5

maaty388 CreditAttribution: maaty388 commented 29 August 2017 at 12:25

Remember to set status to needs review after submitting patch

Comment #6

maaty388 CreditAttribution: maaty388 commented 29 August 2017 at 12:25

Status:

Active

» Needs review

Comment #7

maaty388 CreditAttribution: maaty388 commented 29 August 2017 at 12:28

This patch is working for me

Comment #8

maaty388 CreditAttribution: maaty388 commented 25 September 2017 at 12:36

Status:

Needs review

» Reviewed & tested by the community

Comment #9

12 April 2019 at 21:48

jhedstrom committed 1d3a56a on 8.x-1.x authored by louisnagtegaal

Issue #2903143 by louisnagtegaal: Message without any user

Comment #10

jhedstrom

English

Portland, OR

CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented 12 April 2019 at 21:49

Status:

Reviewed & tested by the community

» Fixed

Awesome, thanks!

+++ b/src/MessageListBuilder.php
@@ -90,7 +90,7 @@ class MessageListBuilder extends EntityListBuilder {
+      'author' => (!empty($entity->getOwner())) ? $entity->getOwner()->label() : t('Anonymous'),

Changed on commit to use $this->t().