Problem/Motivation
In tests, the @group annotation is not used consistently. For example, in the ubercart module some tests use @group twice and some once.
./modules/ubercart/tests/src/Kernel/Migrate/d6/StoreTest.php: * @group commerce_migrate
./modules/ubercart/tests/src/Kernel/Migrate/d6/StoreTest.php: * @group commerce_migrate_ubercart6
/modules/ubercart/tests/src/Kernel/Migrate/d6/MigrateProductAttributeValueTest.php: * @group commerce_migrate
The PHPUnit file structure, namespace, and required metadata handbook page has this: "Group: Generated from the @group PHPDoc annotation. Every test class MUST specify at least one (first) @group that matches the originating module short name (or Drupal core component name)."
That is all I could find.
Proposed resolution
How about using an @group for commerce_migrate and one for the sub modules. Like this,
@group commerce_migrate
@group commerce_migrate_commerce
Remaining tasks
Do it.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#2 | consistent_use_of-2903078-2.patch | 18.65 KB | BramDriesen |
Comments
Comment #2
BramDriesenSomething like this perhaps?
Comment #3
heddnI did a quick review. All looks good here.
Comment #5
heddn