Problem/Motivation

Entity form handlers allow entity form to have dedicated operations and unique ids. Currently all 'add' and 'edit' forms for Webform, WebformSubmission, and WebformSubmission entities use the default handler.

Proposed resolution

Convert Webform, WebformSubmission, and WebformOption entity 'default' form handler to use dedicated 'add' and 'edit' form handlers.

Remaining tasks

  • Update entity annotation.
  • Update routes to 'add' or 'edit'.
  • Fix broken tests.
CommentFileSizeAuthor
#7 convert_webform-2903030-6.patch38.5 KBjrockowitz
#3 convert_webform-2903030-3.patch31.99 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Title: Convert Webform and WebformOption entity 'default' form handler to use dedicated 'add' and 'edit' form handlers. » Convert Webform, WebformSubmission, and WebformOption entity 'default' form handler to use dedicated 'add' and 'edit' form handlers.
Issue summary: View changes
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Active » Needs review
FileSize
convert_webform-2903030-3.patch31.99 KB

  • 229c361 committed on 2903030-refactor-entity-forms 
    Issue #2903030: Convert Webform, WebformSubmission, and WebformOption...

Status: Needs review » Needs work

The last submitted patch, 3: convert_webform-2903030-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • 71691a7 committed on 2903030-refactor-entity-forms 
    Issue #2903030: Convert Webform, WebformSubmission, and WebformOption...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Needs work » Needs review
FileSize
convert_webform-2903030-6.patch38.5 KB

  • jrockowitz authored 9515eee on 8.x-5.x 
    Issue #2903030 by jrockowitz: Convert Webform, WebformSubmission, and...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.