Problem/Motivation

The \Drupal\webform\Access\WebformAccess is handling _custom_access for webform, webform_submission, and accounts.

Proposed resolution

Refactor \Drupal\webform\Access\WebformAccess into more specific classes

  • \Drupal\webform\Access\WebformEntityAccess
  • \Drupal\webform\Access\WebformSubmissionAccess
  • \Drupal\webform\Access\WebformAccountAccess

Remaining tasks

  • Refactor WebformAccess
  • Refactor WebformNodeAccess
CommentFileSizeAuthor
#7 refactor-2903004-6.patch29.12 KBjrockowitz
#3 refactor-2903004-2.patch27.28 KBjrockowitz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • 29e97a5 committed on 2903004-refactor-access-check 
    Issue #2903004: Refactor \Drupal\webform\Access\WebformAccess into more...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
FileSize
refactor-2903004-2.patch27.28 KB
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: refactor-2903004-2.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

  • 7d1e6dc committed on 2903004-refactor-access-check 
    Issue #2903004: Refactor \Drupal\webform\Access\WebformAccess into more...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs work » Needs review
FileSize
refactor-2903004-6.patch29.12 KB

  • jrockowitz authored 2c1aabe on 8.x-5.x 
    Issue #2903004 by jrockowitz: Refactor \Drupal\webform\Access\...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.