XML parser ignores the data-fetcher plugin [#2902819]

Hey, currently i'm working on the migration of an XML based source. The whole migration works fine, if the XML file is stored locally. But if I have to fetch the XML file from an external url, the migration doesn't work. I'm using the data-fetcher plugin and url looks like this:
https://username:password@xyz.de/migration.xml. Eventually it doesn't work because of the protocoll?

The code of the migration:

source:
  plugin: url
  data_fetcher_plugin: http
  data_parser_plugin: xml
  urls:
    - https://username:password@xyz.de/migration.xml
  item_selector: '/dataroot/migration'
  key: default

Regards,

Max

Comment	File	Size	Author
#9	2902819-9.patch	3.27 KB	pfrenssen
#7	migrate_plus-xml_use_fetcher-2902819-7.patch	877 bytes	ahebrank
#6	migrate_plus-xml_use_fetcher-2902819-6.patch	1.16 KB	ahebrank
#4	migrate_plus-xml_use_fetcher-2902819-4.patch	1.21 KB	ahebrank
#3	migrate_plus-xml_use_fetcher-2902819-3.patch	852 bytes	ahebrank

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

17 August 2017 at 09:16

maxpg created an issue. See original summary.

Comment #2

srjosh

he/him

CreditAttribution: srjosh at Phase2 commented 19 February 2019 at 19:06

I have recently found that the http and file parsers handle the item_selector differently. In the example above, try using just 'migration' as the item_selector.

Comment #3

ahebrank CreditAttribution: ahebrank commented 6 November 2019 at 15:20

File	Size
migrate_plus-xml_use_fetcher-2902819-3.patch	852 bytes

The xml parser plugin ignores the fetcher plugin; it directly reads the URL with PHP's XMLReader. If you can use it, the simple_xml parser does use the specified fetcher.

I had a similar problem, needing both the xml parser and fetch authentication, so patched to make the parser use the specified fetcher (fetcher saves to a tmp file, XMLReader reads from the temporary:// uri).

Comment #4

ahebrank CreditAttribution: ahebrank commented 30 April 2021 at 21:57

File	Size
migrate_plus-xml_use_fetcher-2902819-4.patch	1.21 KB

Reroll to fix deprecated function.

Comment #5

ahebrank CreditAttribution: ahebrank commented 30 April 2021 at 22:25

Version:

8.x-4.0-beta1

» 8.x-5.x-dev

Comment #6

ahebrank CreditAttribution: ahebrank commented 3 May 2021 at 14:46

File	Size
migrate_plus-xml_use_fetcher-2902819-6.patch	1.16 KB

Oops, not a static function.

Comment #7

ahebrank CreditAttribution: ahebrank commented 3 May 2021 at 19:20

File	Size
migrate_plus-xml_use_fetcher-2902819-7.patch	877 bytes

2 files were hidden/shown/deleted

File	Size
migrate_plus-xml_use_fetcher-2902819-4.patch	1.21 KB
migrate_plus-xml_use_fetcher-2902819-6.patch	1.16 KB

OK, this one actually applies. Thanks @evac9.

Comment #8

pfrenssen

Sofia

CreditAttribution: pfrenssen at Liip commented 21 March 2023 at 11:06

Title:	Problems with the data-fetcher plugin concerning a XML based external source.	» XML parser ignores the data-fetcher plugin
Category:	Support request	» Feature request
Status:	Active	» Needs work

This works great, thanks for the patch. Setting to needs work to inject the FileSystem service rather than accessing it through the `\Drupal::service()` facade.