In OgMenuTrait::getOgMenuTree() the default menu tree parameters are used to retrieve the menu tree. However, this might cause the $parameters->expandedParents to be set, causing an incomplete tree to be loaded, with only the selected parents being expanded.

We should clear this parameter so that the full tree is returned.

CommentFileSizeAuthor
#5 2902590-5.patch868 bytespfrenssen
#2 2902590-2.patch606 bytespfrenssen
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

pfrenssen created an issue. See original summary.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Active » Needs review
FileSize
2902590-2.patch606 bytes
sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented

Good one! This was a tricky one.
Since we are emptying the parents, we can remove the line 126 that sorts them.

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Needs work
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Needs work » Needs review
FileSize
2902590-5.patch868 bytes

Good catch! Here's a better version.

sardara’s picture

sardara CreditAttribution: sardara at Randstad Digital for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Needs review » Reviewed & tested by the community

Good, straight to RTBC.

pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Reviewed & tested by the community » Fixed

Awesome, thanks for the review!

  • pfrenssen committed 3c2e9f9 on 8.x-1.x 
    Issue #2902590 by pfrenssen, sardara: Make sure the full menu is...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.