Fix head test fails

+++ b/src/Tests/Classic/ParagraphsCoreVersionUiTestTrait.php
@@ -8,26 +8,51 @@ namespace Drupal\paragraphs\Tests\Classic;
+    if ($drupal_version > 8.3) {
+      switch ($submit) {
...
+          $edit['status[value]'] = FALSE;

I don't like to see this code read like outdated 8.3 API and then implicitly make it compatible with >8.3

Instead IMHO it should read like interacting with 8.4+ and implement backwards compatibility.

So there are still some fails left? :-)

+++ b/src/Tests/Classic/ParagraphsCoreVersionUiTestTrait.php
@@ -8,26 +8,51 @@ namespace Drupal\paragraphs\Tests\Classic;
+  protected function paragraphsPostNodeForm($path, $edit, $submit, array $options = [], array $headers = [], $form_html_id = NULL, $extra_post = NULL) {
+    $drupal_version = (float) substr(\Drupal::VERSION, 0, 3);
+    if ($drupal_version > 8.3) {
+      switch ($submit) {
+        case  t('Save and unpublish'):
+          $submit = t('Save');
+          $edit['status[value]'] = FALSE;
+          break;
+
+        case t('Save and publish'):
+          $submit = t('Save');
+          $edit['status[value]'] = TRUE;
+          break;
+
+        case t('Save and keep published (this translation)'):
+          $submit = t('Save (this translation)');
+          break;
+

This is IMHO backwards because as soon as 8.4.0 is stable (if not before, in the past we never cared), there is no reason to keep tests working on 8.3 and we want to remove this stuff again. But then we'd have to change all those calls again.

If we do keep that method, I would recommend to invert it and map to old submit instead.

However, the thing is that all this is only necessary because all our tests have "administer nodes" permission, but you only need that if you want to control revision checkbox or status and a few other things.

Without that permission, it is always just Save, that's what I did in the drag drop test.

So my recommendation would be to remove that permission by default and just do some BC for the few tests that actually need to change revision/status. I would imagine that we have almost no tests doing that.

Committing this from #19 as tests regularly pass.

For 8.3 it seems there's something wrong with the compatibility layer. The condition looks wrong to me.

1. +++ b/src/Tests/Classic/ParagraphsTranslationTest.php
   @@ -112,9 +114,10 @@ class ParagraphsTranslationTest extends ParagraphsTestBase {
          'field_paragraphs_demo[0][subform][status][value]' => FALSE,
   -      'field_paragraphs_demo[1][subform][field_paragraphs_demo][0][subform][field_text_demo][0][value]' => 'Dummy text'
   +      'field_paragraphs_demo[1][subform][field_paragraphs_demo][0][subform][field_text_demo][0][value]' => 'Dummy text',
   +      'status[value]' => FALSE,
        ];
   -    $this->drupalPostForm(NULL, $edit + ['status[value]' => FALSE], t('Save'));
   +    $this->paragraphsPostLegacyNodeForm(NULL, $edit, t('Save'), t('Save and keep published'));
        $this->assertNoText(t('Example published and unpublished'));
   

   this seems wrong, status FALSE but keep published?

2. +++ b/src/Tests/Experimental/ParagraphsExperimentalEntityTranslationWithNonTranslatableParagraphs.php
   @@ -9,6 +11,8 @@ namespace Drupal\paragraphs\Tests\Experimental;
   @@ -79,7 +83,7 @@ class ParagraphsExperimentalEntityTranslationWithNonTranslatableParagraphs exten
   
   @@ -79,7 +83,7 @@ class ParagraphsExperimentalEntityTranslationWithNonTranslatableParagraphs exten
          'title[0][value]' => 'Title English',
        ];
   -    $this->drupalPostForm(NULL, $edit, t('Save'));
   +    $this->paragraphsPostLegacyNodeForm(NULL, $edit, t('Save'), t('Save and publish'));
    
        // Add french translation.
   

   Ah, so a lot of these are needed because we are creating admin roles. Didn't even know that API exists.

   Looks like the only reason for example this class does that is to create languages through the UI, but ConfigurableLangugae::createFromLanguage()->save() is much easier than that and then we might be OK with the standard admin permissions/user?