Hi,

I have added a new region, called 'messages', by editing 'openhand.info.yml' and 'flex-builder.markup.yml'.
It appears in the layout section of the settings.

But the theme settings will not now save.
I make any change - hit 'save layout settings', nothing changes.
No error messages.

'openhand.info.yml' edit;

regions:
  leaderboard: Leaderboard
  header_first: 'Header first'
  header_second: 'Header second'
  navbar: Navbar
  highlighted: Highlighted
  messages: Messages
  features_first: 'Features first'
  features_second: 'Features second'
etc etc

'flex-builder.markup.yml' edit;

rows:
  leaderboard:                  # row key (name of the row).
    attributes:                 # attributes - set id, role, classes.
      id: leaderboard
    regions:
      leaderboard:              # region machine name.
        label: 'Leaderboard'    # region label.
        order: 1                # source order in this row.
  header:
    attributes:
      role: banner
      id: masthead
    regions:
      header_first:
        label: 'Header first'
        order: 1
      header_second:
        label: 'Header second'
        order: 2
  navbar:
    attributes:
      id: navbar
    regions:
      navbar:
        label: 'Navbar'
        order: 1
  highlighted:
    attributes:
      id: highlighted
    regions:
      highlighted:
        label: 'Highlighted'
        order: 1
  messages:
    attributes:
      id: messages
    regions:
      messages:
        label: 'messages'
        order: 1
  features:
    attributes:
      id: features
etc etc

Am I missing something?
Please advise.
Many thanks.

Comments

looklively created an issue. See original summary.

looklively’s picture

looklively CreditAttribution: looklively commented
Issue summary: View changes

It seems to be the 'flex-builder.markup.yml' file.
I have replaced it with the original, leaving the edited 'openhand.info.yml' in place, and all works fine.
But as soon as I add an edited version, I cannot save the theme settings.

Any advice very welcomed.
Thanks.

looklively’s picture

looklively CreditAttribution: looklively commented

I created another sub theme using the generator.
It is saving fine now with the additional region.
So I guess I did something to mess up the othersubtheme.

All good now tho.
Thanks for looking.

looklively’s picture

looklively CreditAttribution: looklively commented

Hi,
So this is still causing me problems.
I see now that I only need to edit 'flex-builder.markup.yml' ... correct ... ?

I have successfully added new regions but have not yet been able to add as many as I need.
The theme settings save, then I add another region and they do not.

Please see the below 2x 'flex-builder.markup.yml'.
The first works - all good, settings save.
The second, with one additinal region, apears in 'layout settings' but the settings will not save .
I am clearing the cache each time.

Is there some limit on the number of regions I can add or something?
Am I doing something wrong or missing something?

This works;

rows:
  leaderboard:                  # row key (name of the row).
    attributes:                 # attributes - set id, role, classes.
      id: leaderboard
    regions:
      leaderboard:              # region machine name.
        label: 'Leaderboard'    # region label.
        order: 1                # source order in this row.
  header:
    attributes:
      role: banner
      id: masthead
    regions:
      header_first:
        label: 'Header first'
        order: 1
      header_second:
        label: 'Header second'
        order: 2
  navbar:
    attributes:
      id: navbar
    regions:
      navbar:
        label: 'Navbar'
        order: 1
  messages:
    attributes:
      id: messages
    regions:
      messages:
        label: 'Messages'
        order: 1
  highlighted:
    attributes:
      id: highlighted
    regions:
      highlighted:
        label: 'Highlighted'
        order: 1
  title-a:
    attributes:
      id: title-a
    regions:
      title-a:
        label: 'Title'
        order: 1
  features:
    attributes:
      id: features
    regions:
      features_first:
        label: 'Features first'
        order: 1
      features_second:
        label: 'Features second'
        order: 2
      features_third:
        label: 'Features third'
        order: 3
      features_fourth:
        label: 'Features fourth'
        order: 4
  main:
    attributes:
      id: main-content
    regions:
      content:
        label: 'Main content'
        order: 1
      sidebar_first:
        label: 'Sidebar first'
        order: 2
      sidebar_second:
        label: 'Sidebar second'
        order: 3
  subfeatures:
    attributes:
      id: sub-features
    regions:
      subfeatures_first:
        label: 'Sub-features first'
        order: 1
      subfeatures_second:
        label: 'Sub-features second'
        order: 2
      subfeatures_third:
        label: 'Sub-features third'
        order: 3
      subfeatures_fourth:
        label: 'Sub-features fourth'
        order: 4
  footer:
    attributes:
      role: contentinfo
      id: footer
    regions:
      footer:
        label: 'Footer'
        order: 1
  twin:
    attributes:
      id: twin
    regions:
      twin_first:
        label: 'Twin first'
        order: 1
      twin_second:
        label: 'Twin second'
        order: 2
  twin2:
    attributes:
      id: twin2
    regions:
      twin2_first:
        label: 'Twin2 first'
        order: 1
      twin2_second:
        label: 'Twin2 second'
        order: 2

This - one additional region at the bottom - does not;

rows:
  leaderboard:                  # row key (name of the row).
    attributes:                 # attributes - set id, role, classes.
      id: leaderboard
    regions:
      leaderboard:              # region machine name.
        label: 'Leaderboard'    # region label.
        order: 1                # source order in this row.
  header:
    attributes:
      role: banner
      id: masthead
    regions:
      header_first:
        label: 'Header first'
        order: 1
      header_second:
        label: 'Header second'
        order: 2
  navbar:
    attributes:
      id: navbar
    regions:
      navbar:
        label: 'Navbar'
        order: 1
  messages:
    attributes:
      id: messages
    regions:
      messages:
        label: 'Messages'
        order: 1
  highlighted:
    attributes:
      id: highlighted
    regions:
      highlighted:
        label: 'Highlighted'
        order: 1
  title-a:
    attributes:
      id: title-a
    regions:
      title-a:
        label: 'Title'
        order: 1
  features:
    attributes:
      id: features
    regions:
      features_first:
        label: 'Features first'
        order: 1
      features_second:
        label: 'Features second'
        order: 2
      features_third:
        label: 'Features third'
        order: 3
      features_fourth:
        label: 'Features fourth'
        order: 4
  main:
    attributes:
      id: main-content
    regions:
      content:
        label: 'Main content'
        order: 1
      sidebar_first:
        label: 'Sidebar first'
        order: 2
      sidebar_second:
        label: 'Sidebar second'
        order: 3
  subfeatures:
    attributes:
      id: sub-features
    regions:
      subfeatures_first:
        label: 'Sub-features first'
        order: 1
      subfeatures_second:
        label: 'Sub-features second'
        order: 2
      subfeatures_third:
        label: 'Sub-features third'
        order: 3
      subfeatures_fourth:
        label: 'Sub-features fourth'
        order: 4
  footer:
    attributes:
      role: contentinfo
      id: footer
    regions:
      footer:
        label: 'Footer'
        order: 1
  twin:
    attributes:
      id: twin
    regions:
      twin_first:
        label: 'Twin first'
        order: 1
      twin_second:
        label: 'Twin second'
        order: 2
  twin2:
    attributes:
      id: twin2
    regions:
      twin2_first:
        label: 'Twin2 first'
        order: 1
      twin2_second:
        label: 'Twin2 second'
        order: 2
  twin3:
    attributes:
      id: twin3
    regions:
      twin3_first:
        label: 'Twin3 first'
        order: 1
      twin3_second:
        label: 'Twin3 second'
        order: 2
jwkovell’s picture

jwkovell CreditAttribution: jwkovell commented

We had a similar issue where our theme's settings form would become bogged down with too many fields to save properly. Maybe our solution will work in your case as well.

Depending on how many regions, content types or view modes you have, some of Adaptive Theme's extensions will exponentially increase the number of fields in the settings form. The Image alignment and captions extension was particularly bad at generating hundreds of form fields.

The solution that ended up working for us was:

  1. Create a new theme
  2. Disable most of Adaptive Theme's extensions
  3. Add content types, view modes, etc. one-by-one and catch when/if it breaks
  4. Re-enable only the extensions you absolutely need

We we able to make due without the "Image alignment and captions" extension, which I believe was enabled by default. You my also have some extensions you don't need that are enabled by default.

looklively’s picture

looklively CreditAttribution: looklively commented

@jkovell,

Halleluijah.
Yes, thanks your solution woked.
I disabled the Image alignment and captions extension, and a few others.
I am now able to add multiple additional regions.

AT is a very good theme indeed, but I guess this kind of thing is the drawback of the kind of settings/interface complexity it facilitates.

Thanks very much for taking the time to help me.
If you pm me a bitcoin or ether address, I'll send you the price of a coffee.
:)

jwkovell’s picture

jwkovell CreditAttribution: jwkovell commented

Glad to help! I'm just glad that your issue reminded me that I should have posted this concern when it first bit me months ago.

Yes, that page IS really complex! Perhaps this should turn into a feature request: "split extension fieldsets out into separate form pages to avoid JavaScript timeout issues" or something like that...

I'll leave that to Jeff to decide if this is more an exception than the norm. For now, the work-around has been sufficient for my own needs.

looklively’s picture

looklively CreditAttribution: looklively commented

+1, buddy.
Gets my vote.

Thanks again for your help.
I was losing hair there ... ;)

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented

"split extension fieldsets out into separate form pages to avoid JavaScript timeout issues" or something like that...

It's a possible case to move it to AT Tools Module, or in fact ALL the extension type settings as sub-modules, something to consider.

Jeff Burnz’s picture

Jeff Burnz CreditAttribution: Jeff Burnz commented
Status: Active » Fixed

I think I will kill enabling Image settings by default, I really want people to use Display Suit anyway as it's far more powerful for laying out stuff.

I'll mark this as fixed for now.

jwkovell’s picture

jwkovell CreditAttribution: jwkovell commented

Sounds good! If the problem did bite someone now, they'd be more likely to associate it with a setting that they enabled, rather than an unknown default. Thanks!

looklively’s picture

looklively CreditAttribution: looklively commented

Hey Jeff,

Yup +1

Sterling work!
Many thanks that man.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

SohelPathan’s picture

SohelPathan CreditAttribution: SohelPathan as a volunteer commented

Yeah....

@jwkovell

Your solution worked for me. Many thanks.

@Jeff,

Have you tacked this issue as suggested by @jwkovell? Because I have faced this issue recently and solved with the solution provided by @jwkovell. I am using AT theme with version 8.x-1.0 and with at_core : 8.x-3.1