Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Advagg allows all functionality to be enabled/disabled by clicking a checkbox in the settings form (see PNG).
The advantage of disabling Advagg from the settings form is that Advagg can be disabled without uninstalling the module altogether which would reset all settings to default.
However, there is no Drush command for this though.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | EnableDisableWithDrush-2901916-1.patch | 2.06 KB | pmagunia |
| |||
| Screen Shot 2017-08-13 at 5.56.32 PM.png | 31.09 KB | pmagunia | |
Comments
Comment #2
pmaguniaThis is a patch I created for this feature request.
Comment #3
pmaguniaComment #4
NickDickinsonWildeNot at my computer, not really working this weekend so haven't reviewed the patch yet.
However, have you tried using the built in drush commend cset? https://drushcommands.com/drush-8x/config/config-set.
Pretty sure that'll work fine with usage like: disable:
drush cset advagg.settings enabled 0Comment #5
pmaguniaThank you for the quick response.
The command
drush cset advagg.settings enabled 0does provide the functionality I had intended.
Comment #6
NickDickinsonWildeGreat! In that case, any reason to add the extra commands? I'd prefer if possible to avoid duplication.
Comment #7
pmaguniaAgreed, it's not good to duplicate code.
I did write the patch under the impression there was no other way to change that setting.
But without knowing the variable's name is
enabledthe user would have to dig through source code which is what I did.Comment #8
NickDickinsonWildehmm yes that is definitely something you'd have to know to use. Would you say that a section mentioning that in the documentation & readme would cover that well enough?
Comment #9
pmaguniaThat would definitely help.
There's a lot of good documentation already.
Should we put something under "Temporarily Disabling Advagg"?
The first place I would look for Drush help though is the command
drush help.If there was a way to add help to Drush without introducing a new command that would be ideal.
Comment #10
NickDickinsonWildeI've investigated and thought and heck, it's a small bit of code, pretty minimal duplication and it is better showing up with
drush list... I'm just gonna commit it, thanks for the patch and discussion!Comment #12
pmaguniaThank you for reviewing the patch! Glad I could help out.
Comment #14
pmagunia@NickWilde, was the patch credit supposed to show up on my profile? I’m not seeing it there.
Comment #15
NickDickinsonWildehmm... that's odd - I can see it on your profile: https://www.drupal.org/u/pmagunia/issue-credits/1066416
If you can't see that, I'm not sure.
Comment #16
pmaguniaI did get credit for contributing to the issue which I do see but shouldn’t there be a commit listed under Projects?