This module can make(convert) the paths(URLs) to relative instead of absolute. It is useful to using the relative URLs. You can find the more details about the relative URL here: https://support.google.com/analytics/answer/2664470

git clone Command: git clone https://git.drupal.org/project/make_paths_relative.git

Project page: https://www.drupal.org/project/make_paths_relative

Reviewed Applications:

  1. https://www.drupal.org/project/shieldsquare
    • use mixed case (camelCase) in ShieldSquare_Integration_init()
    • curly braces { should end a line, not start one [style_curly_braces]
    • Line 15 Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
    • ShieldSquare_Integration_menu () { --- Used mixed case
    • Line 38: missing space after comma
    • Line 40: the final ?> should be omitted from all code files

Comments

sasiddiqui created an issue. See original summary.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Issue summary: View changes
sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Issue summary: View changes

Reviewed ShieldSquare Module

PA robot’s picture

PA robot CreditAttribution: PA robot commented
Issue summary: View changes
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectmake_paths_relativegit

Fixed the git clone URL in the issue summary for non-maintainer users.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

addonsolutions’s picture

addonsolutions CreditAttribution: addonsolutions commented

Hi sasiddiqui,

I have installed this module on my local machine.
and i am getting 404 errors for all css files.

Project name is missing from url.

Example :
http://localhost/PROJECT/CSS_PATH

After the install this module
http://localhost/CSS_PATH

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

Issues has been resolved which is reported on https://pareview.sh/pareview/httpsgitdrupalorgprojectmake_paths_relativegit

@addonsolutions I have checked the project on LIVE Server and it works fine for me. Will be check on local machine.

Have you got some time to check this on Live Server?

Regards,
Sami

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Status: Needs work » Needs review
sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Issue summary: View changes
slowflyer’s picture

slowflyer CreditAttribution: slowflyer commented

Automated Review

[Best practice issues identified by pareview.sh: None found: http://pareview.sh/pareview/httpsgitdrupalorgprojectmake_paths_relativegit

Manual Review

Individual user account
Yes Does follow the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.

Comment
Nice small tool. Working as suggested.

aliyayasir’s picture

aliyayasir CreditAttribution: aliyayasir commented

Simple One. Doesn't found any issue in the code either with Automated Testing Nor with Manual.

Good Job though :)

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Status: Needs review » Reviewed & tested by the community
sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

I have Changed the Status to Reviewed & tested by the community as 2 senior Community Members have reviewed (Automated + Manual) the Module.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

Does anyone else checked the Module?

Stevel’s picture

Stevel CreditAttribution: Stevel commented
Status: Reviewed & tested by the community » Needs review

Please do not mark your own projects as RTBC. See the workflow: https://www.drupal.org/node/532400

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

Stevel, Sorry about that and Thanks for making me correct :)

roychan’s picture

roychan CreditAttribution: roychan as a volunteer and commented

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.

No duplication
Yes: follows

Master Branch
Yes: Follows the guidelines for master branch.

Licensing
Yes: Follows the licensing requirements.

3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.

README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.

Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.

Secure code
Yes: The module meets the security requirements.

Coding style & Drupal API usage
Yes - The code follows the drupal coding standard

Nice and clean, installed and tested, Thanks for contributing to Drupal Community,

roychan’s picture

roychan CreditAttribution: roychan as a volunteer and commented
Status: Needs review » Reviewed & tested by the community
PA robot’s picture

PA robot CreditAttribution: PA robot commented
Status: Reviewed & tested by the community » Closed (duplicate)
Multiple Applications
It appears that there have been multiple project applications opened under your username:

Project 1: https://www.drupal.org/node/2917104

Project 2: https://www.drupal.org/node/2901649

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Status: Closed (duplicate) » Reviewed & tested by the community

As per the above comment, i have closed(duplicate) the other application which has been submitted today and would like to proceed with this.

I am changing the status back to the previous status which was "Reviewed & tested by the community".

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

It's quite long time but didn't heard back from the Drupal Core Team. I can understand that there are bundle of requests and you guys working on it as per your time availability. Kindly, review my request too.

One of the member was marked "Reviewed & tested by the community" but due to opening another thread across other module, this request automatically get closed and i was reopened and marked it again "Reviewed & tested by the community".

Hope, someone can review it again.

Nandu.Kumar’s picture

Nandu.Kumar CreditAttribution: Nandu.Kumar commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Needs work

Hi sasiddiqui,

Kindly see the Automated review of your project

https://pareview.sh/pareview/https-git.drupal.org-project-make_paths_rel...

Review of the 7.x-1.x branch (commit eb701c9):
Your README.txt does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
The INTRODUCTION section is missing.
The REQUIREMENTS section is missing.
The CONFIGURATION section is missing.
The make_paths_relative.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented

Hi Nandu123,

Thanks for looking in it. I have fixed the automated test issues and updated to community version.

Please review it again if you have time.

Thanks,
Sami

sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Status: Needs work » Needs review
sasiddiqui’s picture

sasiddiqui CreditAttribution: sasiddiqui commented
Category: Bug report » Task
sleitner’s picture

sleitner CreditAttribution: sleitner commented
Status: Needs review » Reviewed & tested by the community

Automated Review

Review of the 7.x-1.x branch (commit cd561ee):

  • No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account
Yes: Follows the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements.
Coding style & Drupal API usage
  1. package = SEO in make_paths_relative.info

The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

sleitner’s picture

sleitner CreditAttribution: sleitner commented
Issue summary: View changes
apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented
Assigned: Unassigned » apaderno
Status: Reviewed & tested by the community » Fixed

I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.

apaderno’s picture

apaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
CreditAttribution: apaderno as a volunteer commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.