Week view not displaying correctly [#2901594]

We have a view with separate displays for day/week/month/year.

There are numerous serious issues with the week display.

1) There is js code to set the height of the "single-day-container" element. This code doesn't work properly, and always results in the container having a height of zero. Looking at the code, it is hard to tell precisely what it is intended to do (@see: js/calendar_overlap.js in the calendar_resizeViewport function), since there's little commenting; it isn't clear why one would subtract the top offset, since this can be any value, and frequently causes a zero height table.

2) Less concerning, but still a bug - the code references a grippy icon that doesn't exist in the project, resulting in a 400 error in the console.

3) Events may be sorted into the incorrect time slot, depending on the timezone set in Drupal. This is occurring around line 455 in calendar.theme.inc for the week display, and also effects the day display.

4) It looks like when the display is in overlap mode, if multiple events occur at the same time, only one of them is visible (mostly a css issue, effects day and week displays).

5) Nice to have - it would be good to have the date next to the day names, perhaps in brackets.

Comment	File	Size	Author
#20	calendar-2901594-20.patch	1.48 KB	catch
#20
#19	calendar-2901594-19.patch	1.13 KB	catch
#19
#18	calendar-2901594-18.patch	1.6 KB	catch
#18
#15	week-week-day-display-issues-2901594-15.patch	1.98 KB	acrollet
#15
#14	week-week-day-display-issues-2901594-14.patch	11.24 KB	jeremylichtman
#14
#13	week-week-day-display-issues-2901594-13.patch	11.26 KB	jeremylichtman
#13
#9	week-week-day-display-issues-2901594.patch	3.27 KB	jeremylichtman
#9

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 August 2017 at 16:54

jeremylichtman created an issue. See original summary.

Comment #2

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 17:29

Issue summary:

View changes

Comment #3

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 17:40

Issue summary:

View changes

Comment #4

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 17:41

Issue summary:

View changes

Comment #5

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 18:33

Issue summary:

View changes

Comment #6

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 19:13

Issue summary:

View changes

Comment #7

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 19:23

Issue summary:

View changes

Comment #8

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 19:48

Issue summary:

View changes

Comment #9

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 11 August 2017 at 20:51

File	Size
week-week-day-display-issues-2901594.patch	3.27 KB

The attached patch fixes the following issues:

* Ensures events show in the right time slot (day/week displays) when the Drupal timezone is not UTC.
* Disables the resizing javascript that caused table height to always be zero.
* CSS mods to clean up alignment of the day/week displays

Comment #10

mwmentor CreditAttribution: mwmentor commented 12 August 2017 at 09:38

Hi Jeremy:

Thanks for the patch - works like a charm :)

-M

Comment #11

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 13 August 2017 at 23:29

You're welcome.

Comment #12

sleepingmonk

English

Vancouver Island 🇨🇦

CreditAttribution: sleepingmonk at Cheeky Monkey Media commented 12 September 2017 at 05:39

Hey Jeremy!

Noticed an additional issue with this patch.

While the items are now appearing in the correct time slot on the day and week views, if they're within the difference between UTC and the timezone, they end up on the next day.

To reproduce, create an item with Pacific Timezone (UTC -8), and set the time within 8 hours to midnight.
i.e.: 2017-09-21T21:00:00

This item will appear at 9pm on the 22nd NOT the 21st.

This happens on Day, Week, and Month displays.

Comment #13

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 12 September 2017 at 19:41

File	Size
week-week-day-display-issues-2901594-13.patch	11.26 KB

Reworked the patch from above. The new patch reworks the start/end datetimes at the views row level, so that they are placed into the right buckets in the first place (i.e. instead of trying to sort them into the right buckets at the theme preprocess level).

Comment #14

jeremylichtman CreditAttribution: jeremylichtman as a volunteer and for Cheeky Monkey Media commented 12 September 2017 at 21:06

File	Size
week-week-day-display-issues-2901594-14.patch	11.24 KB

Previous patch had whitespace errors.

Comment #15

acrollet CreditAttribution: acrollet commented 19 December 2017 at 18:04

Status:

Active

» Needs review

File	Size
week-week-day-display-issues-2901594-15.patch	1.98 KB

This patch no longer applies to head - I'm uploading a re-roll that only includes the css/js changes and additionally:

1. adds the missing grippie.png file (no longer in core)
2. uses .length instead of the deprecated .size() method

I'd humbly suggest that it might make sense to split the other concerns into separate issues? Feels like it will be to keep an omnibus patch up to date and get it accepted.

Comment #16

manuga CreditAttribution: manuga at Diputació de Barcelona commented 15 January 2018 at 16:14

Hi, I tried #15 patch and works for me

Comment #17

minorOffense CreditAttribution: minorOffense at Coldfront Labs Inc. commented 22 March 2018 at 21:02

I would say take the 4 issues listed in the description and create issues for each. Then link them to this parent issue. The patch in #15 can be it's own issue as well and set the relation.

That way the maintainer can test the individual items more easily. But looking over what @jeremylichtman did those seem like valuable improvements and we should help get them merged in.

Comment #18

catch

he/him

English

CreditAttribution: catch at Tag1 Consulting commented 2 August 2018 at 07:12

File	Size
calendar-2901594-18.patch	1.6 KB

Patch no longer applied for me, seems to be just context. Here's a re-roll.

Comment #19

catch

he/him

English

CreditAttribution: catch at Tag1 Consulting commented 2 August 2018 at 07:19

File	Size
calendar-2901594-19.patch	1.13 KB

And one without the size/length fix - getting a conflict with other patches in the queue.

Comment #20

catch

he/him

English

CreditAttribution: catch at Tag1 Consulting commented 2 August 2018 at 11:18

File	Size
calendar-2901594-20.patch	1.48 KB

Missed the binary hunk.

Comment #21

oriol_e9g

Catalan

Barcelona

CreditAttribution: oriol_e9g at Diputació de Barcelona commented 2 August 2018 at 11:43

Status:

Needs review

» Reviewed & tested by the community

4 files were hidden/shown/deleted

File	Size
week-week-day-display-issues-2901594-14.patch	11.24 KB

week-week-day-display-issues-2901594-15.patch	1.98 KB

calendar-2901594-18.patch	1.6 KB

calendar-2901594-19.patch	1.13 KB

Aplies and works.

  - Installing drupal/calendar (dev-1.x 1ef5b86): Cloning 1ef5b86b11 from cache
  - Applying patches for drupal/calendar
    https://www.drupal.org/files/issues/2018-08-02/calendar-2901594-20.patch (Week view not displaying correctly)