[D8] Redirect Node [#2901577]

Redirect Nodes provides a node content type specifically designed for only using as a menu item. When these nodes are displayed in the menu, the menu links are rewritten with the value of the destination field provided by the module.

Project: https://www.drupal.org/project/redirect_node

Usage

Instal module as normal. There are no dependencies.
Make sure menus are enabled for the provided content type.
Add a new piece of content of type "Redirect". Set the destination field.
Add a menu link for the new node.

After the above steps, you should see the menu link with the url value replaced by the value of the destination field.

Git Clone:

git clone --branch 8.x-1.x git://git.drupal.org/project/redirect_node.git
cd redirect_node

Comments

Comment #1

11 August 2017 at 15:16

richgerdes created an issue. See original summary.

Comment #2

PA robot CreditAttribution: PA robot commented 11 August 2017 at 16:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectredirect_nodegit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #3

richgerdes

he/him

English

New Jersey, USA

CreditAttribution: richgerdes commented 11 August 2017 at 21:11

Issue summary:	View changes
Status:	Needs work	» Needs review

I applied eslint and Drupal best practice standards.

Comment #4

munish.kumar CreditAttribution: munish.kumar commented 7 September 2017 at 06:20

Issue summary:

View changes

Comment #5

Deepthi kumari CreditAttribution: Deepthi kumari as a volunteer and at TA Digital commented 18 December 2017 at 08:39

Status:

Needs review

» Reviewed & tested by the community

Automated Review

no issues found
https://pareview.sh/node/2623

Found the below warnings in phpcs

FILE: ...p\htdocs\drupal_poc\modules\redirect_node\redirect_node.info.yml
----------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 1 | WARNING | Remove "project" from the info file, it will be added
   |         | by drupal.org packaging automatically
 1 | WARNING | Remove "version" from the info file, it will be added
   |         | by drupal.org packaging automatically
 6 | WARNING | All dependencies must be prefixed with the project
   |         | name, for example "drupal:"
----------------------------------------------------------------------


FILE: ...ules\redirect_node\src\EventSubscriber\RedirectRedirectNodes.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------
 55 | WARNING | \Drupal calls should be avoided in classes, use
    |         | dependency injection instead
 57 | WARNING | Role::loadMultiple calls should be avoided in
    |         | classes, use dependency injection instead
----------------------------------------------------------------------

Comment #6

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 10 May 2018 at 16:40

Assigned:	Unassigned	» apaderno
Status:	Reviewed & tested by the community	» Fixed

Thank you for your contribution!
I am going to update your account so you can opt into security advisory coverage now.
These are some recommended readings to help with excellent maintainership:

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.