Workbench moderation integration

Worked on form settings and storing per bundle.
Defaults in settings are a published status and the first transition from that status to another published status if it exists.

When content is created or updated, we check the workbench moderation settings for uploading if the profile is set as automatic.

Implemented tests
LingotekWorkbenchModerationTest:

• testCreateEntityWithAutomaticProfileAndInUploadState
• testCreateEntityWithAutomaticProfileButNotInUploadState
• testCreateEntityWithManualProfileAndInUploadState
• testCreateEntityWithManualProfileButNotInUploadState
• testModerationToNonUploadStateWithAutomaticProfileDoesntTriggerUpload
• testModerationToNonUploadStateWithManualProfileDoesntTriggerUpload
• testModerationToUploadStateWithAutomaticProfileTriggersUpload
• testModerationToUploadStateWithManualProfileDoesntTriggerUpload
• testUpdateEntityWithAutomaticProfileAndInUploadState
• testUpdateEntityWithAutomaticProfileButNotInUploadState
• testUpdateEntityWithManualProfileAndInUploadState
• testUpdateEntityWithManualProfileButNotInUploadState

\Drupal\lingotek\Tests\LingotekWorkbenchModerationSettingsTest::testWorkbenchModerationSettings

Tests failed because of the test dependency on workbench_moderation. Created and fixed #2901247: Workbench moderation integration: add workbench_moderation to test dependencies.
Rebased patch.

Forgot to include the submit handler in settings form in the patch.
Added phpdoc to LingotekWorkbenchModerationConfigurationService.

We require the dev version of workbench_moderation for the tests, the moderation form doesn't exist in a tagged version.

Re-tested after commiting composer.json that ensures last dev is available.
#2901342: Update composer.json

Only show settings if the bundle is setup as moderatable.
If not, show a text and link to configure moderation.
If the entity does not support moderation, don't show the column.
Tests covering all those cases.

Fixed code standards and solved test failures (workbench moderation needed to be setup before lingotek)

Added handling of the download, with the transition happening (if the source didn't change meanwhile).
Added test for the transition happening on download, when the source status didn't change.
Added test for the transition not happening on download, when the source status changed.

Extract an interface from \Drupal\lingotek\Moderation\LingotekWorkbenchModerationConfigurationService and created Drupal\lingotek\Moderation namespace.

Created another service as workbench moderation handler, for removing as much as possible from the \Drupal\lingotek\LingotekContentTranslationService class and the lingotek.module file.

Fixed services definition and fixed phpdoc packages.

Fixing references to service.

Created a factory for abstracting the different strategies for content moderation. It works with tagged services for allowing extensibility.
Implemented a noop content moderation strategy for when there is no content moderation module enabled, as it makes easy to remove any dependencies.
Let's see if this magic works.

Fixing test failures and code standards.

1. +++ b/lingotek.module
   @@ -123,6 +123,15 @@ function lingotek_entity_insert(EntityInterface $entity) {
   +      // If workbench moderation is enabled, we need to prevent that content is
   +      // processed if not the right state.
   +      /** @var \Drupal\lingotek\Moderation\LingotekWorkbenchModerationHandler $moderation_handler */
   +      $moderation_handler = \Drupal::service('lingotek.workbench_moderation_handler');
   
   @@ -237,6 +246,15 @@ function lingotek_entity_update(EntityInterface $entity) {
   +      // If workbench moderation is enabled, we need to prevent that content is
   +      // processed if not the right state.
   +      /** @var \Drupal\lingotek\Moderation\LingotekWorkbenchModerationHandler $moderation_handler */
   +      $moderation_handler = \Drupal::service('lingotek.workbench_moderation_handler');
   
   +++ b/src/LingotekContentTranslationService.php
   @@ -1050,6 +1050,11 @@ class LingotekContentTranslationService implements LingotekContentTranslationSer
   +      if (\Drupal::moduleHandler()->moduleExists('workbench_moderation')) {
   +        /** @var \Drupal\lingotek\Moderation\LingotekWorkbenchModerationHandler $moderation_handler */
   +        $moderation_handler = \Drupal::service('lingotek.workbench_moderation_handler');
   +        $moderation_handler->performModerationTransitionIfNeeded($entity);
   +      }
   

   Nope, should use the factory instead.

2. +++ b/src/Moderation/LingotekModerationFactory.php
   @@ -0,0 +1,71 @@
   +class LingotekModerationFactory {
   

   phpdocs missing

3. +++ b/src/Moderation/LingotekWorkbenchModerationSettingsForm.php
   @@ -0,0 +1,167 @@
   +    return (\Drupal::moduleHandler()->moduleExists('workbench_moderation') &&
   +      (\Drupal::service('workbench_moderation.moderation_information') !== NULL &&
   +        \Drupal::service('workbench_moderation.moderation_information')
   +          ->isModeratableEntityType($entity_type_definition)));
   ...
   +      $published_statuses = \Drupal::entityQuery('moderation_state')->condition('published', TRUE)->execute();
   ...
   +      $transitions = \Drupal::entityQuery('moderation_state_transition')
   ...
   +    /** @var $moderation_info \Drupal\workbench_moderation\ModerationInformationInterface */
   +    $moderation_info = \Drupal::service('workbench_moderation.moderation_information');
   

   inject services.

Added factory interface. Cleaned up factory.
Removed references to workbench moderation where there shouldn't be.
Added phpdocs.

Missing still test for the factory and injecting services in some places.

Inject services and factory unit tests.

We cannot inject the workbench_moderation services through the services.yml file, as they may not exist.
Instead let's inject the container and get it in the constructor.

+++ b/src/Moderation/LingotekModerationSettingsFormInterface.php
@@ -0,0 +1,107 @@
+  public function getWorkbenchModerationUploadStatuses($entity_type_id, $bundle);
...
+  public function getDefaultWorkbenchModerationUploadStatus($entity_type_id, $bundle);
...
+  public function getWorkbenchModerationDownloadTransitions($entity_type_id, $bundle);
...
+  public function getDefaultWorkbenchModerationDownloadTransition($entity_type_id, $bundle);

This and its implementations shouldn't contain Workbench.

Replaced $entity_id with $entity_type_id and $bundle_id with $bundle for consistency.

Added missing phpdocs.

Oops, missed one reference.

Added check on form submit handler.
Fixing coding standards.

Fixed errors.

Include the from and to states on the transitions, as there may be more than one with same name.

Tests passed as expected. McCann reviewed and suggested the last change in the transition labels.

Committed 4586e89 and pushed to 8.x-2.x. Thanks!