Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Comment | File | Size | Author |
---|---|---|---|
#26 | interdiff-25-26.txt | 1.23 KB | legolasbo |
#26 | 2901134-26.patch | 11.23 KB | legolasbo |
| |||
#25 | 2901134-25.patch | 11.23 KB | rshafakian |
| |||
#15 | do_eck_2901134_15.patch | 11.27 KB | Jaesin |
Comments
Comment #2
msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commentedNow i can't access
admin/structure/eck/entity_type
anymore. It show website encountered an error message.Comment #3
mogio_hh CreditAttribution: mogio_hh commentedSame Here.. this is a mature mature bug.
Comment #4
darvanenI can't reproduce this error, can you post steps to follow on a fresh site?
Comment #5
msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commented@Darvanen I tried with version 8.x-1.0-alpha3. Here are the steps:
1. Create two entities let say Meal and Attendance
2. Add bundle to each of these entities with same name. meal bundle on Meal entity and attendance bundle on Attendance entity.
3. Add couple of fields to both of these bundle.
4. Now try to delete attendance entity.
You should get the error which i provided in description.
Comment #6
MatroskeenComment #7
heyitspython CreditAttribution: heyitspython at Chapter Three commentedI'm also having this issue. Module version: Version: 8.x-1.0-alpha3, Drupal core version: 8.5.1
1. I created an entity and entity bundle both named "in-person location."
2. I added this to a paragraph "required in-person visit" and to another bundle "in person"
3. I deleted the in-person location entity.
4. White screen message "unexpected error."
5. This error displays when I click on ECK under structure now as well.
There are 3 log messages for this event:
Type entity_reference
Date Thursday, April 5, 2018 - 19:34
User admin
Location https://default/admin/structure/eck/entity_type/manage/in_person_locatio...
Referrer https://default/admin/structure/eck/entity_type/manage/in_person_locatio...
Message The field_location entity reference field (entity_type: method, bundle: in_person) no longer has any valid bundle it can reference. The field is not working correctly anymore and has to be adjusted.
Severity Critical
Hostname
Operations
Type entity_reference
Date Thursday, April 5, 2018 - 19:35
User admin
Location https://defaul/admin/structure/eck/entity_type/manage/in_person_location...
Referrer https://default/admin/structure/eck/entity_type/manage/in_person_locatio...
Message The field_location entity reference field (entity_type: paragraph, bundle: _required_in_person_visit_step) no longer has any valid bundle it can reference. The field is not working correctly anymore and has to be adjusted.
Severity Critical
Hostname
Operations
Type php
Date Thursday, April 5, 2018 - 19:35
User admin
Location https://default/admin/structure/eck/entity_type/manage/in_person_locatio...
Referrer https://default/admin/structure/eck/entity_type/manage/in_person_locatio...
Message Drupal\Core\Database\DatabaseExceptionWrapper: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'pantheon.in_person_location__abaee0cc1f' doesn't exist: SELECT 1 AS expression FROM {in_person_location__abaee0cc1f} t WHERE (field_instructions_for_arrival_value IS NOT NULL) OR (field_instructions_for_arrival_format IS NOT NULL) LIMIT 1 OFFSET 0; Array ( ) in Drupal\Core\Entity\Sql\SqlContentEntityStorage->countFieldData() (line 1735 of /app/web/core/lib/Drupal/Core/Entity/Sql/SqlContentEntityStorage.php).
Severity Error
Hostname
Operations
Comment #8
heyitspython CreditAttribution: heyitspython at Chapter Three commentedA new discovery– if you delete the bundle first, then the entity, this error does not occur at first! When you try to create new a new entity however, it brings the whole site into an unexpected error.
Comment #9
Jaesin CreditAttribution: Jaesin at Chapter Three commentedAdding a test only patch for the first test case in this issue.
When deleting an entity type that has a single bundle with the same name, the entity type is allowed to be deleted but causes an error.
Comment #10
Jaesin CreditAttribution: Jaesin at Chapter Three commentedAnother UI test.
Comment #11
Jaesin CreditAttribution: Jaesin at Chapter Three commentedTest against the label instead of the machine name.
Comment #12
Jaesin CreditAttribution: Jaesin at Chapter Three commentedThe way I see it, the issue is with the eck entity delete form:
I'm not sure why a bundle type with the same ID as the eck entity should be treated as a special case but either way this doesn't catch when there are multiple bundles and one matches the id of the entity.
That said, it's not really the issue. This only occurs when there is a bundle with a matching id and some bundle of the entity type has fields.
I created a test that reproduces the 500 error.
Comment #13
Jaesin CreditAttribution: Jaesin at Chapter Three commentedFor the entity delete form, I added a check for actual content. I think it's best to let the parent (core) entity delete form handle the deletion and deal with configuration dependencies no matter how many bundles there are or what their ids are.
Comment #14
Jaesin CreditAttribution: Jaesin at Chapter Three commentedThe previous patch (`do_eck_2901134_13_test-only.patch`) has the fix despite it being named test-only.
Comment #15
Jaesin CreditAttribution: Jaesin at Chapter Three commentedSame patch just renamed. No interdiff.
Comment #16
Jaesin CreditAttribution: Jaesin at Chapter Three commentedComment #18
dqdStart testing ... (ps: shouldn't we patch against latest dev?)
Comment #19
Jaesin CreditAttribution: Jaesin at Chapter Three commentedThe patch applies to the 8.x-1.x branch.
Comment #20
DamienMcKennaI think some tests would be useful.
Comment #21
DamienMcKennaComment #22
Jaesin CreditAttribution: Jaesin at Chapter Three commentedThere are tests in the patch. See:
do_eck_2901134_15.patch
. Let me know if you think something is missing.Comment #23
DamienMcKennaApologies, you are correct.
Comment #25
rshafakian CreditAttribution: rshafakian as a volunteer commentedTests resulted in message "PHP 7 & MySQL 5.5, D8.7 Patch Failed to Apply" Seemed to happen after the tests were corrected. Uploading the new diff file based on the newest code.
Comment #26
legolasboThe patch looks good except for some nitpicks, which I've addressed in this patch. I'll commit this if the patch comes back green.
Comment #28
legolasboCommitted and pushed to 8.x-1.x. Thanks for your contribution!
Comment #29
msankhala CreditAttribution: msankhala at Srijan | A Material+ Company commentedIsn't it a good idea to give credit someone for creating an issue?
Comment #30
legolasboGood point @msankhala,
I'll take issue creation into consideration next time :)