Now that #2870645: PHPCS is failing on contrib modules is fixed, D8 contrib module automated testing is running code sniffs to check for coding standards violations in this module.

The latest test reported two minor errors:

FILE: .../modules/contrib/config_update/src/ConfigListerWithProviders.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
 10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------


FILE: ...pdate/config_update_ui/src/Controller/ConfigUpdateController.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
 71 | ERROR | [ ] Parameter $config_factory is not described in
    |       |     comment
 86 | ERROR | [x] Separate the @param and @praam sections by a blank
    |       |     line.
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

This should be trivial to patch... I think for the second one, the problem is an @param with a typo that says @praam instead, and the first one just needs to have a use statement removed.

CommentFileSizeAuthor
#4 coding-standard-errors-2901018-4.patch1.46 KBarunkumark
#2 coding-standard-errors-2901018-2.patch1.1 KBarunkumark
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhodgdon created an issue. See original summary.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Active » Needs review
FileSize
coding-standard-errors-2901018-2.patch1.1 KB

Good catch @jhodgdon

I have patched for fixing the Coding standards.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

Thanks for the patch! However, it only fixed the first error.

For the second error, as I said in the issue summary:

"the problem is an @param with a typo that says @praam instead"

So that needs a different patch.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
FileSize
coding-standard-errors-2901018-4.patch1.46 KB

@jhodgdon thanks for the comment. I have rerolled the patch by fixing all Coding standards issues.

arunkumark’s picture

arunkumark
Location Coimbatore
CreditAttribution: arunkumark as a volunteer and at DrupalPartners for Innoppl Technologies Pvt. Ltd commented
Status: Needs work » Needs review

  • jhodgdon committed e743798 on 8.x-1.x 
    Issue #2901018 by arunkumark: Coding standards errors
jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Fixed

Thanks -- yes, that is the correct patch. Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.