Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.As can be seen in #2899095: Banner behaviour for "Consent by clicking" is opposite of what's been set in the admin interface where one character was removed from a Javascript, the issue failed to pass tests. It's clear that the tests need to be updated so that we can have the test suite running reliably. Otherwise, if nobody has time to maintain the tests, I suggest that we remove the tests.
The resulting test run https://www.drupal.org/pift-ci-job/732233 lists several errors related to the user logging in and an SQL query that fails.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | eu_cookie_compliance-tests-are-failing-2900209-6.patch | 11.89 KB | svenryen |
Comments
Comment #2
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedIt seems this was due to tests against D8.5 had been configured. I changed configuration to test new patches against 8.3-dev until we can sort out the tests that fail with 8.4 and 8.5. 8.4 is due out in October so we'll have some time to sort this out.
Comment #3
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedI'm quite sure the reason test are failing in D8.5 is due to the old database dump from a previous version.
Since issue #2774143 (for which the only test was written) has passed and is successfully added to the branch, I suggest deleting the test if there are no objections within 2 weeks. Patch is attached.
Comment #4
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedComment #5
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedI missed a few files, will update the patch later today.
Comment #6
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedI can't make any of the tests pass, so I suggest we remove them for now. One of them requires a database dump that adds a lot of weight to the module. The other one should probably be updated so that it works on recent Drupal 8 versions.
If we want to bring them back later, we can revert this commit.
Comment #8
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedComment #9
svenryen CreditAttribution: svenryen at Ramsalt Lab commentedMarking this as outdated. Unless somebody really would like to step up, I don't see tests ever happening in 1.x.