Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
No reason to use diff stack for diff modules in CORE, it makes for harder theme overrides.
font-family: "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
font-family: "Source Sans Pro", "Lucida Grande", Verdana, sans-serif;
font-family: "Lucida Grande", Verdana, sans-serif;
font: normal 81.3%/1.538em "Lucida Grande", "Lucida Sans Unicode", "DejaVu Sans", "Lucida Sans", sans-serif;
font-family: "Lucida Grande", 'Lucida Sans Unicode', 'liberation sans', sans-serif;
font-family: "Droid sans", "Lucida Grande", sans-serif;
In some cases, for example:
font-family: "Lucida Grande", "Lucida Sans Unicode", Verdana, sans-serif;
font-family: "Source Sans Pro", "Lucida Grande", Verdana, sans-serif;Proposed resolution
- Unify the stack in core.
- the fallback font should be the same stack
- Any special cases, we should drop a code comment to explain the reason.
Remaining tasks
- patch
User interface changes
Subtle changes to font family for consistency in core.
API changes
N/A
Data model changes
N/A
Comments
Comment #2
Wim LeersComment #3
Wim LeersIt'd be great if the IS could list where does font stacks came from — i.e. from which CSS files. So it becomes clear which themes are contradicting, and whether there are any modules specifying font stacks.
Comment #4
droplet CreditAttribution: droplet commentedI don't think we need any extra information to make this decision. This is about how we organize the CORE code. and everyone wants to work on this issue should do their own search and read the related CSS to get a sense of why it was doing that way (before agree or disagree with me).
Comment #5
Wim LeersWe do.
Different themes are allowed to have different font stacks. The problem as articulated in the IS is incomplete, and therefore doesn't allow for a proper analysis.
Comment #6
droplet CreditAttribution: droplet commentedProbably, you didn't understand the issue, so you care about the path info. This issue going to remove all differences in CORE, I don't care which theme or module.
the font stack isn't random pick from a random source but after discussion and many follow-ups until today (e.g. #662940: "Lucida Sans Unicode" may match ugly "Lucida Bright" instead of "Lucida Sans")
so if we wanted to use diff font stack, it still okay as I told in IS:
But, I'd recommend this instead:
where it from really doesn't matter.
Comment #7
droplet CreditAttribution: droplet commentedAt the worse case if you really end up with above result in diff modules or themes. I think we still need the following code instead:
(add it before generic family)
It's nonsense we agree one fallback font on another stack but not add to another same font-family stack.
Comment #8
joelpittetThis make's sense there is even Droid sans in some core module CSS font family stacks
This needs to be cleaned up.
Comment #9
Ivan Berezhnov CreditAttribution: Ivan Berezhnov as a volunteer and at Drupal Ukraine Community for Levi9 commented