It's unnecessary to log all downloads to watchdog() when the module already logs its own records to the {download_count} and {download_cache} tables. At the very least it should be optional.

CommentFileSizeAuthor
#2 download_count-n2899963-2.patch2.21 KBDamienMcKenna
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DamienMcKenna created an issue. See original summary.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Active » Needs review
FileSize
download_count-n2899963-2.patch2.21 KB

This makes the watchdog logging optional.

Michelle’s picture

Michelle
she/her
Primary language English
Location Wisconsin, USA
CreditAttribution: Michelle at Mediacurrent commented

I think the form item description could be simplified. Maybe "Optionally log downloads to the watchdog system in addition to the download count table."? Not sure it's necessary to add the part about it adding a lot of records as that's sort of a given. Knowing that the information is available elsewhere is important, though, and being more specific about where would be good.

gnuget’s picture

gnuget
Primary language Spanish
CreditAttribution: gnuget as a volunteer and at Agaric commented
Issue tags: +needs port to Drupal 8