entity_translation_upgrade_do needs to automatically create the entity_translation row for the source language in entity_translation

PLEASE COMMIT! Lets get this in right away, plan for a 1.0 release!

Funny you mention that @stefanos.petrakis , I grabbed that code VERBATIM from 7.x-1.x dev of entity_translation

so if it's needs work in my patch, then entity_translation 7.x-1.x dev needs work.

see this screenshot line 231 of entity_translation.admin.inc :

now look at the patch:

+      // Initialize translations if they are empty.
+      $translations = $handler->getTranslations();
+      if (empty($translations->original)) {
+        $handler->initTranslations();
+        $handler->saveTranslations();
+      }

SAME=SAME

it works, passes testing, and conforms exactly to the entity_translation module, copied verbatim.

The code is fired when the 'translate' link is clicked, that's where I copied the code from.

The same operation must occur in the entity_translation_upgrade_do during an entity_translation_upgrade

Somewhere between beta5 and the current 1.x dev , this became an issue, or perhaps I didn't notice it before.

But yes, the patch is needed, would prefer to perform refactoring in a new ticket, I maintain my call for RTBC, feel free to make a new change to the logic as long as it works , but this patch works as is, and is following the design pattern set up by the developers of entity_translation.

a bit inconsistent, as in

as in, ? what? entity_translation? lol

the patch >is< consistent with entity_translation, as described.

Want a side order of chicken and some fries with that?

Ok, I protest, but if you insist.

here's another one, not sure why #19 failed , been a long day.

this unrelated code sniffer patch was autogenerated , interesting, nice job drupal.org , if you're going to complain, at least be helpful about it.
https://dispatcher.drupalci.org/job/drupal_d7/31890/artifact/jenkins-dru...

tabarnak de câlissse

looks like handler object has a problem with pointers or pass by reference?

who cares?

ALRIGHT, it was a nice though, ok, back to PATCH 5 yet????????????????????????

ok, back to patch 5

patch 30 failed too.

stefanos.petrakis
can we just go with patch 5 ?

or can you please explain to me why patch 30 isn't working?

Nice work Stefanos, the tests pass except an unrelated strict warning

Nice, the tests are requeued after the unrelated issue was fixed.

expecting a pass.

Ok, so the tests without the fix and with the fix prove that the fix is needed and is working.

+    // Check that the body is displayed when the active language is English.
+    $this->drupalGet('node/' . $node->nid);
+    $this->assertRaw($node_body, t('Body field displayed correctly in the source language.'));
+
+    // Check that the translated body is displayed when the active language is Spanish.
+    $this->drupalGet('es/node/' . $node->nid);
+    $this->assertRaw($node_translation_body, t('Body field displayed correctly in the target language.'));

without the fix, this will fail

WITH the fix, it passes.

RTBC this one:
https://www.drupal.org/files/issues/entity_translation-upgrade_fix_with_...
upgrade fix with tests.

Thanks Stefanos for awesome tests!

71 passes

Thanks very much!

btw, I created a freebie patch for you based on the d.o code sniffer results from one of my failed patches (above).

see the patch here:
#2900094: Run a coder review on the ET codebase

Credit should also go to dsutter and gdaw, dsutter for finding the needle in the haystack, and gdaw for his thorough quality assurance.

Thanks everyone!