Wrong render of HTML from label when field is shared across languages in error message

Created a patch that removes the span HTML. Does anyone know if this HTML is needed for anything? I could not find any code that is using the 'translation-entity-all-languages' class.

Will this problem be solved by #2652850: Title for details form elements is not set as '#markup' and it will be escaped, but all other form elements use '#markup' and are not escaped?

It does solve #2833031: Field label shows HTML if field is marked as not translatable which is almost the same.

I had a similar issue recently on one of the projects.
Attaching a patch.

I.e. HTML markup is still being escaped for the validations errors (so issues above do not resolve this problem)

Patch applies and works for inline errors in Drupal 9.2.x

I was still noticing raw html in error messages at the top of the page and decided to track this down to the source. Submitted patch formats the combined title and translation hint suffix for html display.

Thanks for the patch. Some nitpicks:

1. +++ b/core/modules/content_translation/src/ContentTranslationHandler.php
   @@ -414,9 +415,9 @@ public function entityFormAlter(array &$form, FormStateInterface $form_state, En
   -          $this->getTranslationAccess($entity, 'delete')->isAllowed() ||
   -          ($entity->access('delete') && $this->entityType->hasLinkTemplate('delete-form'))
   -        );
   +            $this->getTranslationAccess($entity, 'delete')->isAllowed() ||
   +            ($entity->access('delete') && $this->entityType->hasLinkTemplate('delete-form'))
   +          );
   

   Unrelated formatting change.

2. +++ b/core/modules/content_translation/src/ContentTranslationHandler.php
   @@ -648,6 +649,8 @@ protected function addTranslatabilityClue(&$element) {
   +      $formatted_title = new FormattableMarkup($element['#title'], []);
   +      $element['#title'] = $formatted_title;
   

   This can be one line.

Other than that, I'm pretty sure this needs a test to make sure that HTML in the field label is rendered correctly in the error message. What I'm not sure about: Is the translation hint the only place where HTML is added to the field label? Or can we find a more general approach to this?

Addressed the changes specified in #20.1 and #20.2, thanks!

Fixed issue summary to correctly show the < and >

It appears that this issue has been resolved in the latest version of Drupal 11. I have tested the scenario and verified that the error message no longer includes the "(all languages)" suffix.

I have attached a screenshot for reference. Given that the problem is no longer present, I believe we can close this issue.

Thank you!

Not everyone is on 11.x yet... This is rerolled for 10.3.x.

Changes are made on on 11.x (our main development branch) first, and are then back ported as needed according to the Core change policies.

This is changing a user facing error message so will need before and after screenshots. They should be available to reviewers/committers from the Issue Summary.

This also needs an issue summary update, add the standard issue template and complete the 'Problem/Motivation', 'Steps to reproduce', and 'Proposed resolution' sections. Leave the other sections empty for use by other contributors.

https://www.drupal.org/project/drupal/issues/2899338#comment-15774058

It appears that this issue has been resolved in the latest version of Drupal 11.

@pobster, thanks for repeating that this is fixed in D11. I couldn't find the issue where this was fixed but it wasn't backported to D10.

Thanks everyone for working on this issue. The current error message should render the HTML correctly, However, this

I agree that the current string is somewhat misleading, and the suggested change would improve it. However, Drupal 10 is in maintenance mode and this issue doesn't meet the criteria for an allowed change in a maintenance minor,

Therefor, I am closing this issue as won't fix.