Update Thunder to Drupal 8.4 [#2899242]

Problem/Motivation

Drupal 8.4 is on it's way.

Proposed resolution

As soon as Drupal 8.4-alpha will be released, we can test Thunder with it.

Remaining tasks

Update Drupal and test everything

User interface changes

API changes

Data model changes

Comments

Comment #1

2 August 2017 at 08:01

chr.fritsch created an issue. See original summary.

Comment #2

chr.fritsch

he/him

German

🇩🇪🇪🇺🌍

CreditAttribution: chr.fritsch at Thunder commented 7 August 2017 at 07:15

I did a first test. Some things i found:

Toolbar in admin theme broken
Our custom tour's are not working any more
In thunder-project and thunder-infrastructure we have to switch to drush 9

Additionally we could

Enable "Inline form errors" module. It's stable now

See branch https://github.com/BurdaMagazinOrg/thunder-distribution/tree/feature/289...

Comment #3

chr.fritsch

he/him

German

🇩🇪🇪🇺🌍

CreditAttribution: chr.fritsch at Thunder commented 29 August 2017 at 12:39

Toolbar is fixed in #2905049: Theme not compatible with D8.4
Tours are working in beta1 again

So we are now 8.4-beta1 compatible. Let's leave the ticket open until 8.4 is released

Comment #4

chr.fritsch

he/him

German

🇩🇪🇪🇺🌍

CreditAttribution: chr.fritsch at Thunder commented 11 October 2017 at 10:59

Status:

Active

» Fixed

Thunder now on Drupal 8.4

Comment #5

anruether

German

Bonn

CreditAttribution: anruether commented 11 October 2017 at 11:14

I'm running into this error on drush updb after composer update:

...Do you wish to run all pending updates? (y/n): y
The following module is missing from the file system: contact_formatter bootstrap.inc:250                      [warning]
Invalid argument supplied for foreach() thunder_updater.module:26                                              [warning]
array_walk_recursive() expects parameter 1 to be array, string given thunder_updater.module:53                 [warning]
array_reverse() expects parameter 1 to be array, string given thunder_updater.module:55                        [warning]
Error: Unsupported operand types in thunder_updater_checklistapi_checklist_info() (line 55 of                  [error]
/var/www/lpms_bl/docroot/profiles/contrib/thunder/modules/thunder_updater/thunder_updater.module) #0 [internal
function]: thunder_updater_checklistapi_checklist_info()
...

The Website only gives me a WSOD and the error.log says:

[Wed Oct 11 11:13:55.888055 2017] [proxy_fcgi:error] [pid 1427:tid 140097873704704] [client 192.168.88.1:52816] AH01071: Got error 'PHP message: Error: Unsupported operand types in /var/www/lpms_bl/docroot/profiles/contrib/thunder/modules/thunder_updater/thunder_updater.module on line 55 #0 [internal function]: thunder_updater_checklistapi_checklist_info()\n#1 /var/www/lpms_bl/docroot/core/lib/Drupal/Core/Extension/ModuleHandler.php(402): call_user_func_array('thunder_updater...', Array)\n#2 /var/www/lpms_bl/docroot/modules/contrib/checklistapi/checklistapi.module(110): Drupal\\Core\\Extension\\ModuleHandler->invokeAll('checklistapi_ch...')\n#3 /var/www/lpms_bl/docroot/modules/contrib/checklistapi/checklistapi.module(55): checklistapi_get_checklist_info('thunder_updater')\n#4 /var/www/lpms_bl/docroot/profiles/contrib/thunder/modules/thunder_updater/src/UpdateChecklist.php(62): checklistapi_checklist_load('thunder_updater')\n#5 /var/www/lpms_bl/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php(270): Drupal\\thunder_updater\\UpdateChecklist->__construct(Object(Drupal\\Core\\Config\\ConfigFactory), Object(Drupal\\Core\\Extension\\Modul...\n'