Fix tests for 8.3.x

Running the tests locally on my 8.3 sandbox:

$ simpletest83 metatag 2>/dev/null

Drupal test run
---------------

Tests to be run:
- Drupal\metatag\Tests\MetatagAdminTest
- Drupal\metatag\Tests\MetatagConfigTranslationTest
- Drupal\metatag\Tests\MetatagCustomRouteTest
- Drupal\metatag\Tests\MetatagFieldNodeTest
- Drupal\metatag\Tests\MetatagFieldTermTest
- Drupal\metatag\Tests\MetatagFieldTestTest
- Drupal\metatag\Tests\MetatagFieldUserTest
- Drupal\metatag\Tests\MetatagForumTest
- Drupal\metatag\Tests\MetatagFrontpageTest
- Drupal\metatag\Tests\MetatagNodeTranslationTest
- Drupal\metatag\Tests\MetatagTagsTest
- Drupal\metatag\Tests\MetatagTagTypesTest
- Drupal\metatag\Tests\MetatagXssTest
- Drupal\metatag_app_links\Tests\MetatagAppLinksTagsTest
- Drupal\metatag_dc\Tests\MetatagDublinCoreTagsTest
- Drupal\metatag_dc_advanced\Tests\MetatagDublinCoreAdvancedTagsTest
- Drupal\metatag_facebook\Tests\MetatagFacebookTagsTest
- Drupal\metatag_favicons\Tests\MetatagFaviconsTagsTest
- Drupal\metatag_google_cse\Tests\MetatagGoogleCSETagsTest
- Drupal\metatag_google_plus\Tests\MetatagGooglePlusTagsTest
- Drupal\metatag_hreflang\Tests\MetatagHreflangTagsTest
- Drupal\metatag_mobile\Tests\MetatagMobileTagsTest
- Drupal\metatag_open_graph\Tests\MetatagOpenGraphTagsTest
- Drupal\metatag_open_graph_products\Tests\MetatagOpenGraphProductsTagsTest
- Drupal\metatag_twitter_cards\Tests\MetatagTwitterCardsTagsTest
- Drupal\metatag_verification\Tests\MetatagVerificationTagsTest
- Drupal\Tests\metatag\Functional\EnsureDevelWebProfilerWorks
- Drupal\Tests\metatag\Functional\EnsureDevelWorks
- Drupal\Tests\metatag\Functional\NodeJsonOutput
- Drupal\Tests\metatag\Kernel\MetatagManagerTest

Test run started:
Tuesday, August 1, 2017 - 15:11

Test summary
------------

Drupal\metatag\Tests\MetatagCustomRouteTest 6 passes
Drupal\metatag\Tests\MetatagConfigTranslationTest 87 passes
Drupal\metatag\Tests\MetatagFieldNodeTest 200 passes
Drupal\metatag\Tests\MetatagAdminTest 237 passes
Drupal\metatag\Tests\MetatagFieldTestTest 154 passes
Drupal\metatag\Tests\MetatagForumTest 17 passes
Drupal\metatag\Tests\MetatagFieldTermTest 302 passes
Drupal\metatag\Tests\MetatagFrontpageTest 105 passes
Drupal\metatag\Tests\MetatagNodeTranslationTest 60 passes 12 fails
- Found database prefix 'test61017915' for test ID 40.
Drupal\metatag\Tests\MetatagTagsTest 259 passes
Drupal\metatag_app_links\Tests\MetatagAppLinksTagsTest 314 passes
Drupal\metatag\Tests\MetatagTagTypesTest 87 passes
Drupal\metatag_dc\Tests\MetatagDublinCoreTagsTest 215 passes
Drupal\metatag\Tests\MetatagFieldUserTest 194 passes
Drupal\metatag\Tests\MetatagXssTest 108 passes
Drupal\metatag_dc_advanced\Tests\MetatagDublinCoreAdvancedTa 50 passes
Drupal\metatag_facebook\Tests\MetatagFacebookTagsTest 83 passes
Drupal\metatag_favicons\Tests\MetatagFaviconsTagsTest 281 passes
Drupal\metatag_google_cse\Tests\MetatagGoogleCSETagsTest 105 passes
Drupal\metatag_hreflang\Tests\MetatagHreflangTagsTest 38 passes 18 fails 1 exceptions
- Found database prefix 'test87329864' for test ID 51.
Drupal\metatag_google_plus\Tests\MetatagGooglePlusTagsTest 105 passes
Drupal\metatag_mobile\Tests\MetatagMobileTagsTest 402 passes
Drupal\metatag_open_graph\Tests\MetatagOpenGraphTagsTest 468 passes
Drupal\metatag_twitter_cards\Tests\MetatagTwitterCardsTagsTe 392 passes 40 fails 1 exceptions
Drupal\metatag_open_graph_products\Tests\MetatagOpenGraphPro 50 passes
- Found database prefix 'test17491179' for test ID 55.
Drupal\Tests\metatag\Functional\EnsureDevelWebProfilerWorks 1 passes
Drupal\Tests\metatag\Kernel\MetatagManagerTest 1 passes
Drupal\metatag_verification\Tests\MetatagVerificationTagsTes 116 passes
Drupal\Tests\metatag\Functional\EnsureDevelWorks 1 passes
Drupal\Tests\metatag\Functional\NodeJsonOutput 0 passes 1 exceptions
FATAL Drupal\Tests\metatag\Functional\NodeJsonOutput: test runner returned a non-zero error code (2).
Drupal\Tests\metatag\Functional\NodeJsonOutput 0 passes 1 fails

Test run duration: 8 min 37 sec

So there are a few classes that have errors:

• Drupal\metatag\Tests\MetatagNodeTranslationTest
• Drupal\metatag_hreflang\Tests\MetatagHreflangTagsTest
• Drupal\metatag_twitter_cards\Tests\MetatagTwitterCardsTagsTest
• Drupal\Tests\metatag\Functional\NodeJsonOutput

One of the errors on the content translation tests is the following:

POST request to:

Ending URL: http://d83.dev/admin/config/regional/content-language

Fields: <?php array (
'entity_types[node]' => 'node',
'settings[node][metatag_node][translatable]' => '1',
'settings[node][metatag_node][settings][language][langcode]' => 'site_default',
'settings[node][metatag_node][fields][status]' => '1',
'settings[node][metatag_node][fields][title]' => '1',
'settings[node][metatag_node][fields][uid]' => '1',
'settings[node][metatag_node][fields][created]' => '1',
'settings[node][metatag_node][fields][changed]' => '1',
'settings[node][metatag_node][fields][promote]' => '1',
'settings[node][metatag_node][fields][sticky]' => '1',
'settings[node][metatag_node][fields][body]' => '1',
'settings[node][metatag_node][fields][field_metatag_field]' => '1',
'settings[user][user][settings][language][langcode]' => 'site_default',
'settings[user][user][fields][changed]' => '1',
'form_build_id' => 'form-skGPL8gtCvcoSaOfcdZ3juwhUF5NwOQgQ3oi14yR5b4',
'form_token' => 'yoQ15GcRzJfh3vMSGXAsDYgU2YrqO0dVaM-3qUc28n4',
'form_id' => 'language_content_settings_form',
'op' => 'Save configuration',
)
The website encountered an unexpected error. Please try again later.

Drupal\Core\Field\FieldException: Attempt to create a base field bundle override of field Metatags without an entity_type in Drupal\Core\Field\Entity\BaseFieldOverride->__construct() (line 101 of core/lib/Drupal/Core/Field/Entity/BaseFieldOverride.php).

This is weird.

This fixes MetatagNodeTranslationTest.php.

The tests all work correctly locally for me now. I'm committing this.

Not done yet.

The branch tests pass now. Woot.