[D8] Open Social

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectsocialgit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Automated Review

pareview.sh shows a huge amount of messages.
A lot of messages can be cleared by running PHPCBF (CAN FIX THE n MARKED SNIFF VIOLATIONS AUTOMATICALLY)
I suggest to do this first to reduce the huge amount of messages

Manual Review

Individual user account
Yes Does follow the guidelines for individual user accounts.
No duplication
Yes: Does not cause module duplication and/or fragmentation.
Master Branch
Yes: Follows the guidelines for master branch.
Licensing
Yes: Follows the licensing requirements.
3rd party assets/code
Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md
Yes: Follows the guidelines for in-project documentation and/or the README Template.
Code long/complex enough for review
Yes: Follows the guidelines for project length and complexity.
Secure code
Yes: Meets the security requirements. / No: List of security issues identified.]

Others
I found an inconsitency in installation methods:
https://www.drupal.org/node/2901220

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

I just tried to do another pareview.sh run, but it failed. I also don't see where we can read previous runs?

What remains to be done here? How much progress was made in making OpenSocial's code style comply with Drupal's coding standards?

3rd party libraries don't need to comply with coding standards.

Can't you add a phpcs.xml file to Open Social to exclude 3rd party libraries from coding standards checks?

Hi Wim,

Correct, but we did not had much or any issues with 3rd party PHP coding standards.

Our main issue were the JavaScript libraries. And for some reason, which I can't remember, we could not get PAReview.sh to ignore certain files or paths. And so we decided to increase the scope and fix the maintainability issues for these libraries at the same time.

We just merged the pull requests which contains all these changes, we'll push it to Drupal.org soon. And then we can see how much we still have left to fix.

Anything that is still left we'll give high priority as we are committed to getting it right!

👏🎉

A lot of fixes have been done and are now available in the dev branch. I'm putting this on review to also have the automated bot do some tests.

We still have work to do, but the majority of the issues is now gone. Still about 300 (mainly minor) issues left, we're trying to fix those coming week.

If anyone already wants to do a manual review this is much appreciated.

Note: the changes made with regard to the 3rd libraries require a manual change in your project's composer.json file. Please see https://www.drupal.org/docs/8/distributions/open-social/updating-open-so... first if you run into any trouble.

Hi there!

We managed to fix nearly all issues. Tomorrow at the DrupalCon sprint we will deliver a dev version on drupal.org for retesting.

@Wim Leers are you available for a review tomorrow? I’m able (or other OS devs) to talk you through any questions you have.

Other manual reviews are also very welcome!

@bramtenhove: Sorry — I was in hard problems meetings pretty much the entire time on Friday, and then I had to catch my flight.

It'd be great if we could get feedback from a maintainer of this issue queue.

Hi Wim, thanks for your comment. I already noticed during Friday that you were kind of busy :)

Agreed, that would be great. We'll be doing another review of one of the projects in the issue queue soon to get us self some more exposure too.

You should've come and said hi though! :)

We just pushed some more code to Drupal.org and it is ready for manual review. The automated checks are done, you can view the result here: https://pareview.sh/node/2591.

We are aware that there are issues shown in the automated review. There are for example some warnings about dependency injections, we will be fixing these issues gradually during the coming time.

Next to the these warnings you will also notice a lot of errors for .css files. We will not be fixing them as these files are generated based upon our SCSS files. The Pareview.sh script should already ignore them automatically, but there might be a glitch there (see https://github.com/klausi/pareviewsh/blob/7.x-1.x/pareview.sh#L256).

Just to show that we already fixed a ton of coding style issues, the first test result (https://pareview.sh/node/2591/revisions/11398/view) was pretty bad.

Continue, based on my remarks on #5:

I spend a huge amount of time on Open Social in the last couple of month. Not only reviewing the code, more a learning how to use the distro, how to expand and how to solve issues I found on my way. Therefore I provided patches whenever possible.
I felt really comfortable, how code is structured and how things are implemented.
The last thing I reviewed yesterday and today where the Social API and Social Auth modules for log in using external Accounts (Facebook, Twitter, …). I did not find any issues on that.
From my point of view, the last open issue from pareview.sh, should not block Open Social from getting the “Security Advisory”.

Woot, https://www.drupal.org/project/social is now covered by the security advisory policy! 🎉

Great work, everyone!

Great community effort!! Love to see the project in the green and covered :)