Fix tests for 8.4.x [#2898805]

The 8.4.x tests are failing because the node save form changed from having a "Save and publish" button to one that simply says "Save".

8.3.x:
Drupal 8.3.x's node form.

8.4.x:
Drupal 8.4.x's node form.

Comment	File	Size	Author
#27	metatag-n2898805-27.patch	2.32 KB	DamienMcKenna
#27	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 111 pass, 2 fail
#25	metatag-n2898805-24.patch	2.32 KB	DamienMcKenna
#25	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 112 pass, 1 fail
#23	metatag-n2898805-23.patch	2.31 KB	DamienMcKenna
#23	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted
#21	metatag-n2898805-21.patch	2.27 KB	DamienMcKenna
#21	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 112 pass, 1 fail
#16	metatag-n2898805-16.patch	19.15 KB	DamienMcKenna
#16	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 110 pass, 3 fail
#16	metatag-n2898805-16.interdiff.txt	2.4 KB	DamienMcKenna
#15	metatag-n2898805-15.patch	19.73 KB	DamienMcKenna
#15	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted
#15	metatag-n2898805-15.interdiff.txt	2.21 KB	DamienMcKenna
#14	metatag-n2898805-14.interdiff.txt	4.78 KB	DamienMcKenna
#14	metatag-n2898805-14.patch	19.81 KB	DamienMcKenna
#14	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 113 pass
#11	metatag-n2898805-11.interdiff.txt	1.85 KB	DamienMcKenna
#11	metatag-n2898805-11.patch	16.6 KB	DamienMcKenna
#11	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 110 pass, 3 fail
#10	metatag-n2898805-10.patch	17 KB	DamienMcKenna
#10	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 108 pass, 4 fail
#5	metatag-n2898805-5.patch	17.09 KB	DamienMcKenna
#5	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted
#4	metatag-n2898805-4.patch	12.5 KB	DamienMcKenna
#4	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted PHP 7 & MySQL 5.5, D8.3 CI aborted
#2	metatag-n2898805-84.png	9.13 KB	DamienMcKenna
#2	metatag-n2898805-83.png	10.02 KB	DamienMcKenna

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

31 July 2017 at 19:28

DamienMcKenna created an issue. See original summary.

Comment #2

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 July 2017 at 19:29

Issue summary:

View changes

File	Size
metatag-n2898805-83.png	10.02 KB
metatag-n2898805-84.png	9.13 KB

Comment #3

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 July 2017 at 19:29

2 files were hidden/shown/deleted

File	Size
metatag-n2898805-83.png	10.02 KB
metatag-n2898805-84.png	9.13 KB

Comment #4

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 July 2017 at 20:40

Status:

Active

» Needs review

File	Size
metatag-n2898805-4.patch	12.5 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted PHP 7 & MySQL 5.5, D8.3 CI aborted

This appears to fix the problem locally.

Comment #5

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 31 July 2017 at 21:08

File	Size
metatag-n2898805-5.patch	17.09 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted

Had some occasions where standardizing on using "$edit" as the variable name for form submissions resulted in conflicts.

Comment #6

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 1 August 2017 at 02:00

Parent issue:

#2563617: Plan for Metatag 8.x-1.2 release

» #2898881: Plan for Metatag 8.x-1.3 release

Taking this off the slate for 1.2

Comment #7

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 14:53

Related issues:

+#2899045: Fix tests for 8.3.x

Comment #8

2 August 2017 at 15:49

The last submitted patch, 4: metatag-n2898805-4.patch, failed testing. View results

Comment #9

2 August 2017 at 15:49

Status:

Needs review

» Needs work

The last submitted patch, 5: metatag-n2898805-5.patch, failed testing. View results

Comment #10

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 17:40

Status:

Needs work

» Needs review

File	Size
metatag-n2898805-10.patch	17 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 108 pass, 4 fail

Rerolled.

Comment #11

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 18:40

File	Size
metatag-n2898805-11.patch	16.6 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 110 pass, 3 fail
metatag-n2898805-11.interdiff.txt	1.85 KB

Fixes for two of the tests.

Comment #12

2 August 2017 at 18:40

The last submitted patch, 10: metatag-n2898805-10.patch, failed testing. View results

Comment #13

2 August 2017 at 19:11

Status:

Needs review

» Needs work

The last submitted patch, 11: metatag-n2898805-11.patch, failed testing. View results

Comment #14

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 19:59

Status:

Needs work

» Needs review

File	Size
metatag-n2898805-14.patch	19.81 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 113 pass
metatag-n2898805-14.interdiff.txt	4.78 KB

Almost there.

Comment #15

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:02

File	Size
metatag-n2898805-15.interdiff.txt	2.21 KB
metatag-n2898805-15.patch	19.73 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted

Additional improvements to MetatagFrontpageTest.

Comment #16

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:06

File	Size
metatag-n2898805-16.interdiff.txt	2.4 KB
metatag-n2898805-16.patch	19.15 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 110 pass, 3 fail

Only need one helper trait.

Comment #17

2 August 2017 at 20:06

The last submitted patch, 15: metatag-n2898805-15.patch, failed testing. View results

Comment #18

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:13

9 files were hidden/shown/deleted

File	Size
metatag-n2898805-4.patch	12.5 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted PHP 7 & MySQL 5.5, D8.3 CI aborted
metatag-n2898805-5.patch	17.09 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.5 CI aborted
metatag-n2898805-10.patch	17 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 108 pass, 4 fail
metatag-n2898805-11.patch	16.6 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 110 pass, 3 fail
metatag-n2898805-11.interdiff.txt	1.85 KB
metatag-n2898805-14.patch	19.81 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 113 pass
metatag-n2898805-14.interdiff.txt	4.78 KB
metatag-n2898805-15.interdiff.txt	2.21 KB
metatag-n2898805-15.patch	19.73 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted

Comment #19

2 August 2017 at 20:20

DamienMcKenna committed 8088dfb on 8.x-1.x

Issue #2898805 by DamienMcKenna: Small improvements to the test suite,...

Comment #20

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:20

The tests worked with 8.3.x so I've committed them. Now to resolve the last 8.4.x problems.

Comment #21

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:40

File	Size
metatag-n2898805-21.patch	2.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 112 pass, 1 fail

This fixes the translation tests locally.

Comment #22

2 August 2017 at 20:49

Status:

Needs review

» Needs work

The last submitted patch, 21: metatag-n2898805-21.patch, failed testing. View results

Comment #23

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:53

Status:

Needs work

» Needs review

File	Size
metatag-n2898805-23.patch	2.31 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted

1 file was hidden/shown/deleted

File	Size
metatag-n2898805-21.patch	2.27 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 112 pass, 1 fail

Combined the two trinary operators.

Comment #24

2 August 2017 at 20:56

Status:

Needs review

» Needs work

The last submitted patch, 23: metatag-n2898805-23.patch, failed testing. View results

Comment #25

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 20:57

Status:

Needs work

» Needs review

File	Size
metatag-n2898805-24.patch	2.32 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 112 pass, 1 fail

1 file was hidden/shown/deleted

File	Size
metatag-n2898805-23.patch	2.31 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.3 CI aborted

Fix a typo.

Comment #26

2 August 2017 at 21:02

Status:

Needs review

» Needs work

The last submitted patch, 25: metatag-n2898805-24.patch, failed testing. View results

Comment #27

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 21:05

Status:

Needs work

» Needs review

File	Size
metatag-n2898805-27.patch	2.32 KB
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 111 pass, 2 fail

Ok, the label was wrong. This works locally.

Comment #28

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 21:14

So it works with 8.3.x but fails on 8.5.x. Going to try 8.4.x next.

Comment #29

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 21:24

Status:

Needs review

» Needs work

Argh - the tests work locally but fail on testbot :-\

Comment #30

2 August 2017 at 21:25

DamienMcKenna committed 0de431f on 8.x-1.x

Issue #2898805 by DamienMcKenna: Fixes to MetatagNodeTranslationTest to...

Comment #31

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 2 August 2017 at 21:26

I've committed the fix for MetatagNodeTranslationTest so now there's just EnsureDevelWebProfilerWorks.

Comment #32

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 5 August 2017 at 23:45

Status:

Needs work

» Postponed

The WebProfiler tests fail because the Devel module needs another release, see #2900162: Plan for Devel 8.x-1.0-rc3 for details.

Comment #33

DamienMcKenna

NH, USA

CreditAttribution: DamienMcKenna at Mediacurrent commented 17 August 2017 at 16:09

Status:

Postponed

» Fixed

Now that Devel 1.0 has been released the tests are passing. Yay!

Comment #34

31 August 2017 at 16:09

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.