Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I set my bundler to 15 for css and 15 for js according to ticket https://www.drupal.org/node/2897555. However, with the bundler at 15, certain project/H5P javascript is broken. But when setting the bundler back to 5 it then works.
I have PMed you a page that demonstrates the broken js.
Comments
Comment #2
mikeytown2 CreditAttribution: mikeytown2 commentedLooks like a minification issue. Can I get a zip of the page with core and advagg js disabled?
This is where the JS is having issues
Comment #3
webservant316 CreditAttribution: webservant316 commentedPMed you the requested page. It works as you guessed. What's next?
Comment #4
mikeytown2 CreditAttribution: mikeytown2 commentedIt's a issue with the minifier in use.
Using https://github.com/CreateJS/SoundJS/blob/master/lib/soundjs-0.6.2.combin... instead of https://github.com/CreateJS/SoundJS/blob/master/lib/soundjs-0.6.2.min.js might help.
If not the regex needs fixing in the js file.
This
a.ABSOLUTE_PATT=/^(?:\w+:)?\/{2}/i,a.RELATIVE_PATT=/^[./]*?\//i,a.EXTENSION_PATT=/\/?[^/]+\.(\w{1,5})$/i
Should be this (escape / with \).
a.ABSOLUTE_PATT=/^(?:\w+:)?\/{2}/i,a.RELATIVE_PATT=/^[.\/]*?\//i,a.EXTENSION_PATT=/\/?[^\/]+\.(\w{1,5})$/i
The minifier sees // as an inline comment and cuts off the rest of the JS file. You can also tell advagg to not compress this file.
Comment #5
webservant316 CreditAttribution: webservant316 commentedThanks @mikeytown2. The problem is now fixed over here https://www.drupal.org/node/2803319.
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedGlad to hear you got the bottom of this issue!
Comment #7
paalj CreditAttribution: paalj commentedThanks @mikeytown2 for getting to the bottom of this one. You have been mentioned here:
h5p.org/post-hub-releases