Can't switch gateways from Braintree

Which other gateways do you have on the form? Is it the same no matter from which one you switch?

Looking further into this I can see that on detach commerceBraintree.integration.teardown() is being called in commerce_braintree.form.js when changing payment method - at that moment in time the integration object is null so the call fails. I can't seem to spot where the integration object is added to the commerceBraintree object.

Changing commerceBraintree.integration.teardown() to commerceBraintree.hostedFieldsInstance.teardown() results in teardown executing successfully, but then receive the js error 'tokenize cannot becalled after teardown' on submit, regardless of which method I'm using.

Any pointers in the right direction would be greatly appreciated.

Thanks

This patch changes teardown to act on the current hostingFieldsInstance instead of 'integration', as well as unbinding the submit handler on teardown which wasn't happening previously

Updated patch to namespace the form submit handler - this way we don't blindly blanket unbind anything else bound to submit.

1. +++ b/js/commerce_braintree.form.js
   @@ -44,9 +44,10 @@
   -      commerceBraintree.integration.teardown();
   

   I think the more generic option is chosen as there will be support for PayPal via Braintree.

2. +++ b/js/commerce_braintree.form.js
   @@ -44,9 +44,10 @@
   +      $form.off('submit.braintreeSubmit');
   
   @@ -79,7 +80,7 @@
   +        $form.on('submit.braintreeSubmit', function (event, options) {
   

   But how is this event triggered?

1. In our case, with multiple payments in addition to braintree the integration object was never created, so teardown() could never be called.
2. It's a namespaced submit handler... in essence it's just a standard form submit handler. Namespacing it means I can remove specifically that handler instead of blanket removing all handlers attached to form submit.

Going to sit down on this today. I feel some of the JS changes in https://www.drupal.org/node/2331119 may fix this as well. Will cherrypick as needed.

Here is a much simpler fix. The problem was that teardown was not a proper value. A fix is to ensure there is a immplementationInstance property. Using a generic property like this can then hold either the HostedField or PayPal (once implemented) and allow easy setup and teardown.

Attaching much simpler patch.

Can confirm that this patch did fix the problem. so +1 for RTBC. A before patch screenshot error.

Unfortunately, having applied this patch, I get the error:

uncaught exception: BraintreeError: tokenize cannot be called after teardown.

Steps to reproduce:
1. Checkout and save card
2. Checkout again and switch from saved card to new card
3. Switch back from new card to saved card.
4. Try to "continue to review", see the error in the console.

Sorry, had to finish this comment quickly earlier so I left off a step by mistake.

I will be re-rolling a new patch about https://www.drupal.org/node/2331119 and I am having the same error described in #15. This means we need to find a proper way to teardown and these both issues will have fix...

Thanks Sophie.SK! We should try to fix the issue here first, which should improve our JavaScript and make implementing the PayPal items easier.

Let put it back to needs work based on #15

mrhorse had this fix we discovered in #15. I'm just stupid and totally didn't understand namespaced event handling. I'd like to keep the teardown to `integration.teardown`, so my fix in #12 and then also original patch from #7.

Here is tweak. Authorship should go to mrhorse in #7.

#19 Looks good to me.

Sophie.SK, mrhorse : with your RTBC blessing we can merge.

Works perfectly for me! Thanks for pinging me to check this, and for the fix! Marking as RTBC.

(I would record a fancy gif, but I don't know how :-))

Ugh, just making sure that if I do get any kind of credit for testing a patch :D, it marks my organisation too. Not quite sure why d.o has done away with my settings for that.

Yep works great for us! Go forth and use namespaced submit handlers :P

Thanks all

Thank you, everyone!