Problem/Motivation

I've run phpcs against the code. Now to clean it up.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2898182.patch378.03 KBheddn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

heddn created an issue. See original summary.

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented
FileSize
2898182.patch378.03 KB

commerce_migrate_example module is from d7. No need to keep it in d8. We can add an example later. Right now it violates a ton of code standards.

I've also added phpcs as a dev dependency and ran phpcbf against all violations.

  • heddn committed 4c2de79 on 8.x-2.x 
    Issue #2898182 by heddn: Code standards

  • heddn committed 21a8f92 on 8.x-2.x 
    Issue #2898182 by heddn: Code standards
  • heddn committed 84aedb0 on 8.x-2.x
    Revert "Issue #2898182 by heddn: Code standards"

This reverts commit...
heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC, Acro Commerce commented

Hmm, I muffed that up a little while merging in #2894123: Move commerce to submodule. But now it should be a clean commit.

quietone’s picture

quietone CreditAttribution: quietone at Acro Commerce commented
Status: Active » Fixed

Yes, I think it is. Closing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.