Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.When I was integrating this subscription service to one of the projects I found this missing use cases:
1. Anonymous subscription of already subscribed email.
As anonymous if I click subscription form with the same email that was previously confirmed:
expected behaviour: I should have subscribe button toggled to unsubscribe & see message something like - your mail was already subscribed, if you need unsubscribe it please click unsubcribe
actual behaviour: button is toggled (which is correct) but there is message : "bla bla bla please confirm submission" which is incorrect as this mailbox already was confirmed & confuses users, it happens coz of wrong requiresConfirmation processing
2. Anonymous unsubscribe.
As anonymous if I click unsubscribe on a previously opened form while somebody e.g. admin or me over email confirmed unsubscribe:
expected behaviour: I should see your mail was unsubscribed.
actual behaviour: there is message : "bla bla bla please confirm submission cancellation" which is incorrect as this mailbox already was confirmed & unsubscribed & confuses users, it happens coz of wrong requiresConfirmation processing
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | anonymous-subscription-require-confirm-fix-2898053-2.patch | 3.13 KB | Pavel Ruban |
Comments
Comment #2
Pavel Ruban CreditAttribution: Pavel Ruban as a volunteer and commentedComment #3
Pavel Ruban CreditAttribution: Pavel Ruban as a volunteer and commentedComment #5
Pavel Ruban CreditAttribution: Pavel Ruban as a volunteer and commentedComment #6
jonathanshawGreat catches Pavel.
This is going to need tests.
Comment #7
AdamPS CreditAttribution: AdamPS at AlbanyWeb commentedConfirm that normal policy for this module is that tests are needed - in the long run it's the best way to get a stable module.
There can be exceptions for example if you are fixing a small bug in a certain feature, and there are no existing tests to adapt.