I have checked code manually. I'm found classes name write with the full namespace. use statement should be used for defining the class.either drupal through coding standards error. please review.

CommentFileSizeAuthor
#2 Use_statement_in_module_2897651_1.patch1.12 KBAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented

mayank010 created an issue. See original summary.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous as a volunteer and commented
FileSize
Use_statement_in_module_2897651_1.patch1.12 KB

I have make patch for this. please apply and review

bserem’s picture

bserem CreditAttribution: bserem at zehnplus commented
Status: Active » Fixed

Thanks for the review and the patch. It has been applied.

Side note:
The attached patch file is identified as a binary file on my linux system.
Git doesn't recognize it, and less previews this as follows.
Maybe you want to check your editor!

<FF><FE>d^@i^@f^@f^@ ^@-^@-^@g^@i^@t^@ ^@a^@/^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@.^@m^@o^@d^@u^@l^@e^@ ^@b^@/^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@.^@m^@o^@d^@u^@l^@e^@^M^@
^@i^@n^@d^@e^@x^@ ^@2^@6^@1^@9^@9^@6^@8^@.^@.^@b^@0^@a^@f^@9^@5^@2^@ ^@1^@0^@0^@6^@4^@4^@^M^@
^@-^@-^@-^@ ^@a^@/^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@.^@m^@o^@d^@u^@l^@e^@^M^@
^@+^@+^@+^@ ^@b^@/^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@.^@m^@o^@d^@u^@l^@e^@^M^@
^@@^@@^@ ^@-^@5^@,^@1^@0^@ ^@+^@5^@,^@1^@2^@ ^@@^@@^@^M^@
^@ ^@ ^@*^@ ^@A^@n^@ ^@C^@S^@S^@ ^@C^@a^@c^@h^@e^@ ^@B^@u^@s^@t^@e^@r^@ ^@f^@o^@r^@ ^@D^@8^@.^@^M^@
^@ ^@ ^@*^@/^@^M^@
^@ ^@^M^@
^@+^@u^@s^@e^@ ^@D^@r^@u^@p^@a^@l^@\^@C^@o^@r^@e^@\^@A^@s^@s^@e^@t^@\^@A^@t^@t^@a^@c^@h^@e^@d^@A^@s^@s^@e^@t^@s^@I^@n^@t^@e^@r^@f^@a^@c^@e^@;^@^M^@
^@+^@^M^@
^@ ^@/^@*^@*^@^M^@
^@ ^@ ^@*^@ ^@I^@m^@p^@l^@e^@m^@e^@n^@t^@s^@ ^@h^@o^@o^@k^@_^@c^@s^@s^@_^@a^@l^@t^@e^@r^@(^@)^@.^@^M^@
^@ ^@ ^@*^@/^@^M^@
^@-^@f^@u^@n^@c^@t^@i^@o^@n^@ ^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@_^@c^@s^@s^@_^@a^@l^@t^@e^@r^@(^@&^@$^@c^@s^@s^@,^@ ^@\^@D^@r^@u^@p^@a^@l^@\^@C^@o^@r^@e^@\^@A^@s^@s^@e^@t^@\^@A^@t^@t^@a^@c^@h^@e^@d^@A^@s^@s^@e^@t^@s^@I^@n^@t^@e^@r^@f^@a^@c^@e^@ ^@$^@a^@s^@s^@e^@t^@s^@)^@ ^@{^@^M^@
^@+^@f^@u^@n^@c^@t^@i^@o^@n^@ ^@c^@a^@c^@h^@e^@b^@u^@s^@t^@e^@r^@_^@c^@s^@s^@_^@a^@l^@t^@e^@r^@(^@&^@$^@c^@s^@s^@,^@ ^@A^@t^@t^@a^@c^@h^@e^@d^@A^@s^@s^@e^@t^@s^@I^@n^@t^@e^@r^@f^@a^@c^@e^@ ^@$^@a^@s^@s^@e^@t^@s^@)^@ ^@{^@^M^@
^@ ^@ ^@ ^@f^@o^@r^@e^@a^@c^@h^@ ^@(^@$^@c^@s^@s^@ ^@a^@s^@ ^@&^@$^@f^@i^@l^@e^@)^@ ^@{^@^M^@
^@ ^@ ^@ ^@ ^@ ^@$^@f^@i^@l^@e^@[^@'^@t^@y^@p^@e^@'^@]^@ ^@=^@ ^@'^@e^@x^@t^@e^@r^@n^@a^@l^@'^@;^@^M^@
^@ ^@ ^@ ^@ ^@ ^@$^@f^@i^@l^@e^@[^@'^@d^@a^@t^@a^@'^@]^@ ^@=^@ ^@'^@/^@'^@ ^@.^@ ^@$^@f^@i^@l^@e^@[^@'^@d^@a^@t^@a^@'^@]^@;^@^M^@
^@
Use_statement_in_module_2897651_1.patch (END)

  • bserem committed 42d2700 on 8.x-1.x authored by mayank010 
    Issue #2897651 by mayank010: classes should be referenced with use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.