dot in username prevents sandbox project from being recognized by simplytest.me

Logic should be this:

http://cgit.drupalcode.org/simplytest/tree/modules/simplytest_projects/s...

josepholstad is compatible with simplytest.me sandbox projects
whereas joseph.olstad is not.

hm.. that's odd because my manual fix for your sandbox project was actually adding the dot, not removing it..

ah sorry, my fault, the issue is not when the git url is build after loading it from database. it happens after scrapping the data from the drupal.org url which happens here:
http://cgit.drupalcode.org/simplytest/tree/modules/simplytest_projects/s...

it fetches the project data from here:
https://www.drupal.org/api-d7/node.json?field_project_machine_name=2635830
and scraps the username from the URL contained in the response at list[0].url which is
https://www.drupal.org/sandbox/josepholstad/2635830

this is where the dot is *missing*

the only other mention of a user/author seems to be
https://www.drupal.org/api-d7/user/1321830
but that gives 404

yup, I'm starting to remember now, this is the same issue as 5 years ago, there seems to be no good way to fetch the author name :/

oh!

https://www.drupal.org/api-d7/user.json?uid=1321830

contains the field name:"joseph.olstad"

so it's possible to ensure the correct username by doing a second request based on the author.id from the first api request

Not sure I understand why we should change yours back, it's working now, so let's just leave it at that and fix the fetch for future projects.
And if we want correct all existing projects we can simply truncate the database and reimport all projects from scratch.
Otherwise you'd have to fetch the name every time a project is selected which would be really bad for performance and send useless requests to d.o.

just trying to give something back here.

No worries, i'm just bad at explaining things because I keep assuming you know things that are obvious to me because i created this thing.

so that we can verify a permanent fix to the code base. Rather than a one-off fix for just me, we should fix the logic to handle the dot.

Yes, I think with that json data we can actually fix it for everyone and not just you *but* only for projects which are not in the database yet. As the problem lies in the function (simplytest_projects_fetch_project) adding *new* projects to the database.

What needs to be changed:
* The author should not be scrapped from the project URL anymore
* Instead a second d.o API request needs to be done to https://www.drupal.org/api-d7/user.json?uid=
* The UID can be found in list[0].author.id from the first api request
* From the response from there list[0].name should be used as author instead

I hope I explained it better :)

Is this still an active issue? Trying to ensure the queue has relevant issues in it and this one has not seen activity since before major changes to the platform.

Please set to active if still relevant. Please set to Closed (outdated) if not.