Problem/Motivation

We need to add the og:price:amount and og:price:currency tags.

Proposed resolution

Add the tags.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#11 Capture du 2018-03-29 21-40-21.png25.3 KBzenimagine
#7 add-2897450-7.patch2.51 KBedurenye
#7 interdiff-add-2897450-5-7.txt2.91 KBedurenye
#5 interdiff-add-2897450-3-5.txt1.07 KBedurenye
#5 add-2897450-5.patch2.43 KBedurenye
#3 add-2897450-3.patch2.41 KBedurenye
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

edurenye created an issue. See original summary.

edurenye’s picture

edurenye CreditAttribution: edurenye at ENDPHASYS Technologies commented
Related issues: +#2663974: Add remaining OG meta tags to D8
edurenye’s picture

edurenye CreditAttribution: edurenye at ENDPHASYS Technologies commented
Status: Active » Needs review
FileSize
add-2897450-3.patch2.41 KB

Added both tags, those are the more important ones for product.

Status: Needs review » Needs work

The last submitted patch, 3: add-2897450-3.patch, failed testing. View results

edurenye’s picture

edurenye CreditAttribution: edurenye at ENDPHASYS Technologies commented
Status: Needs work » Needs review
FileSize
add-2897450-5.patch2.43 KB
interdiff-add-2897450-3-5.txt1.07 KB

Fixed the name-space and added tags to test.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Needs work

According to Facebook's documentation these should have the prefix "product" instead of "og".

edurenye’s picture

edurenye CreditAttribution: edurenye at ENDPHASYS Technologies commented
Status: Needs work » Needs review
FileSize
interdiff-add-2897450-5-7.txt2.91 KB
add-2897450-7.patch2.51 KB

Ok, I changed it to the product prefix.

  • DamienMcKenna committed a1dcb15 on 8.x-1.x authored by edurenye 
    Issue #2897450 by edurenye: Add product:price:amount and product:price:...
DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Status: Needs review » Fixed
Parent issue: » #2932455: Plan for Metatag 8.x-1.5

Committed. Thanks.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Assigned: edurenye » Unassigned
zenimagine’s picture

zenimagine CreditAttribution: zenimagine commented
FileSize
Capture du 2018-03-29 21-40-21.png25.3 KB

Thank you for this update. "Open graph - products" would not dervrait be in the menu accordion "Open Graph"? Or just below.

DamienMcKenna’s picture

DamienMcKenna
Location NH, USA
CreditAttribution: DamienMcKenna at Mediacurrent commented
Title: Add product:price:amount and product:price:currency OG tags » Add product:price:amount and product:price:currency OG tags (D8)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.