DevelController is quite a messy and contains a lot of methods, used for different functionalities. We should move each different functionality (when it make sense) in a dedicated controller.

The attached patch:
- moves element info method in a dedicated controller
- uniforms the output of the page (currently a raw dump) to the other devel functionalities (see screenshot)
- allow to open the element detail in a modal instead of open it in a new page (see screenshot)
- adds test coverage

CommentFileSizeAuthor
#2 move_element_info-2896727-2.patch11.74 KBwillzyx
detail-output.png168.92 KBwillzyx
page-output.png130.48 KBwillzyx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

willzyx created an issue. See original summary.

willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Active » Needs review
FileSize
move_element_info-2896727-2.patch11.74 KB
moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman at Acquia commented
Status: Needs review » Reviewed & tested by the community

Thanks for adding test coverage.

  • willzyx committed b38f0a0 on 8.x-1.x 
    Issue #2896727 by willzyx: Move element info methods to a dedicated...
willzyx’s picture

willzyx CreditAttribution: willzyx commented
Status: Reviewed & tested by the community » Fixed

Pushed and committed to 8.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.