Entity lookup not working correctly for "non-entity" destinations

This patch works for us; I'll let someone else set this to RTBC since I work with jigarius and this should be reviewed by someone at another organization.

Great find. Bumping back to NW for tests. We're really trying hard to beef up testing on this.

+1
The patch at #2 worked as expected. Another case for this is the book destination plugin, which does not have the bundle in the destination name.

I understand the value of tests, but IMHO delaying applying a know fix to a known bug for this long may not be the best strategy for a contributed module.
Core may be different because of the amount of contributions it receives.

Here a test only patch that should fail, and the complete patch.

Also, linking a related ticket for tests on entity_lookup plugin.

A small extra change related to coding standards.

Thanks for your contributions, especially the tests.

Changes made on commit:

     $this->destinationEntityType = empty($pluginIdParts[1]) ? NULL : $pluginIdParts[1];
-    $this->destinationBundleKey = !$this->destinationEntityType ? NULL : $this->entityManager->getDefinition($this->destinationEntityType)->getKey('bundle');
+    $this->destinationBundleKey = $this->destinationEntityType ? $this->entityManager->getDefinition($this->destinationEntityType)->getKey('bundle') : NULL;
   }

     $this->assertSame($known_user->id(), $value);
     // Check an unknown user is not found.
     $value = $plugin->transform('orange', $executable, $row, 'name');
-    $this->assertNotSame($known_user->id(), $value);
+    $this->assertNull($value);
   }