I'm having the same issue, if I remove the patch, infinite scroll no longer works in an eva view.

CommentFileSizeAuthor
#9 2896459-9.patch1.29 KBvuil
#8 views_infinite_scroll-eva_support-2896459-8.patch1.29 KBmichael.barlow@mirumagency.com
#6 views_infinite_scroll-eva_support-2896459-6.patch2.05 KBDaniel Kulbe
#4 views_infinite_scroll_eva_support-2896459-4.patch593 bytesWatergate
#2 EVA_views_now_support_infinite_scroll.patch862 bytesamarincolas
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

amarincolas created an issue. See original summary.

amarincolas’s picture

amarincolas CreditAttribution: amarincolas commented
FileSize
EVA_views_now_support_infinite_scroll.patch862 bytes
Grimreaper’s picture

Grimreaper
Primary language French
Location France 🇫🇷
CreditAttribution: Grimreaper as a volunteer commented
Status: Active » Needs work

Hello,

Thanks for the patch, just what I need.

The patch works, but please see my points in the review.

You should have changed the status to "needs review" to have it reviewed. And unassigned the issue if it was ok for you.

Please change the status to "needs review" once uploading a new patch with the points taken into account.

  1. +++ b/views_infinite_scroll.module
@@ -51,3 +51,20 @@ function views_infinite_scroll_preprocess_views_view(&$vars) {
+

    Missing PHP Doc comment:
    /**
    * Implements hook_preprocess_eva_display_entity_view().
    */ 

  2. +++ b/views_infinite_scroll.module
@@ -51,3 +51,20 @@ function views_infinite_scroll_preprocess_views_view(&$vars) {
+function views_infinite_scroll_preprocess_eva_display_entity_view(&$variables) {

    The content of the hook is a duplication of the content of views_infinite_scroll_preprocess_views_view. I think it would be good to factorize the code into a function called in both hooks.

And thanks again for the patch.

Watergate’s picture

Watergate CreditAttribution: Watergate at Sicse commented
Status: Needs work » Needs review
FileSize
views_infinite_scroll_eva_support-2896459-4.patch593 bytes

Thanks for the patch, I can confirm that it works. I've attached a new patch to this issue, based on the comments of Grimreaper in #3

macherif’s picture

macherif
Location Paris
CreditAttribution: macherif as a volunteer and commented

I tried with the patch but in my case it did'nt worked. So I added entity language = current language and that's works !! (I kept the patch)

Daniel Kulbe’s picture

Daniel Kulbe
he/him
Primary language German
Location Berlin
CreditAttribution: Daniel Kulbe as a volunteer commented
FileSize
views_infinite_scroll-eva_support-2896459-6.patch2.05 KB

I still have issues when the EVA is attached to a rendered entity within an other view.

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Specbee commented
Status: Needs review » Closed (cannot reproduce)
michael.barlow@mirumagency.com’s picture

michael.barlow@mirumagency.com CreditAttribution: michael.barlow@mirumagency.com commented
Issue summary: View changes
FileSize
views_infinite_scroll-eva_support-2896459-8.patch1.29 KB
vuil’s picture

vuil
Location Bulgaria 🇧🇬 🇪🇺 🌍
CreditAttribution: vuil at FFW commented
Version: 8.x-1.x-dev » 8.x-1.8
Status: Closed (cannot reproduce) » Needs review
FileSize
2896459-9.patch1.29 KB

The issue still exists and I create a similar to the #8 patch that resolve the issue on 8.x-1.8 stable version. I reopen the issue and put it in status Needs review. Thanks!

Neslee Canil Pinto’s picture

Neslee Canil Pinto
he/him
Primary language English
CreditAttribution: Neslee Canil Pinto at Ramsalt Lab commented
Version: 8.x-1.8 » 8.x-1.x-dev
Assigned: amarincolas » Unassigned
Status: Needs review » Fixed
Issue tags: -views views_infinite_scroll

@vuil had a look at this again and #9 works, just had a nit change

+   *   Wether to apply the Views AJAX paginator. VIS requires this setting

Changed Wether to Whether while committing.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.