Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There is no need for this function to be public. It will only be used by classes that extend this class
Comment | File | Size | Author |
---|---|---|---|
#12 | enableTheme-should-protected-2896366-12.patch | 804 bytes | arunkumark |
#3 | enabletheme___should_be_protected_not_public_function_in_outsideinjavascripttestbase-2896366-3.patch | 804 bytes | cdmo |
Comments
Comment #2
cdmo CreditAttribution: cdmo commentedI'll give this a shot!
Comment #3
cdmo CreditAttribution: cdmo commentedThat it?
Comment #4
tedbow@cdmo, yep thats it.
Besides letting someone else getting a commit credit the other reason I didn't do it myself is I can't mark my own patch RTBC.
So thanks!
Comment #5
cdmo CreditAttribution: cdmo commentedCool. Easy contribution process!
I'm off to add "Drupal Core Contributor" to my resume ;)
Comment #6
Wim LeersNice catch! :) And thanks, @cdmo!
Comment #7
tedbowComment #9
lauriiiI definitely agree this should be protected instead of public. Making functions more private is always a small BC break. Because this only affects Settings Tray module which is still in Alpha, we are allowed to make this change.
Committed 67e1d78 and pushed to 8.4.x. Thanks!
Waiting for confirmation to commit this to 8.3.x.
Comment #11
Wim LeersComment #12
arunkumarkHi,
I have re-rolled patch for the Drupal 8.x.3 version as per the comment #9
Comment #13
Wim LeersThanks!
Comment #14
star-szr8.3.x is now essentially criticals only, and this is in 8.4.x (and 8.5.x), so marking fixed. Thanks all!
Comment #15
Wim LeersThanks!
Comment #17
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)