Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
In the Settings Tray we specify 2 blocks that have different form classes for 'settings_tray
', SystemBrandingOffCanvasForm and SystemMenuOffCanvasForm and also specify that 3 blocks should have no settings_tray
form.
After Settings Tray is stable this should be moved to the respective modules
this will remove all updating of the "forms" in settings_tray_block_alter()
except to set the plugin class itself as the settings_tray
form if it is not set.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2896356-9.patch | 7.19 KB | tedbow |
#9 | interdiff-6-9.txt | 781 bytes | tedbow |
#6 | 2896356-6.patch | 7.19 KB | tedbow |
Comments
Comment #2
Wim LeersThis is blocked on #2762505: Introduce "outside in" quick edit pattern to core being fixed, i.e. Settings Tray becoming stable.
Comment #4
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)
Comment #6
tedbownow all stable blockers have been fixed in #2922603: Mark Settings Tray module as stable
but we might want to do it before to make the stable patch as simple as possible.
Comment #7
Wim LeersJust one nit:
s/use use/use/
Also, wouldn't "fall back" be more accurate?
Comment #8
Wim LeersForgot to say: other than that one nit, this looks splendid :) Months in the making!
Comment #9
tedbow@Wim Leers thanks for review
Nit fixed!
Comment #10
Wim LeersComment #11
xjmWe decided to merge this in with #2922603: Mark Settings Tray module as stable. I will add credit for Wim over there.