Trying to use it in a site with webprofiler module enabled, going to admin/config/search/metatag/global gives just a white screen with a fatal error.
Just a guess, i did not try it: maybe we can replace the type hint "EntityTypeManager $entityTypeManager" to use one interface, and not the class name.

The website encountered an unexpected error. Please try again later.
TypeError: Argument 5 passed to Drupal\metatag\MetatagManager::__construct() must be an instance of Drupal\Core\Entity\EntityTypeManager, instance of Drupal\webprofiler\Entity\EntityManagerWrapper given, called in /var/www/novo/public/core/lib/Drupal/Component/DependencyInjection/Container.php on line 284 in Drupal\metatag\MetatagManager->__construct() (line 42 of modules/metatag/src/MetatagManager.php).
Drupal\metatag\MetatagManager->__construct(Object, Object, Object, Object, Object) (Line: 284)
Drupal\Component\DependencyInjection\Container->createService(Array, 'metatag.manager') (Line: 177)
Drupal\Component\DependencyInjection\Container->get('metatag.manager') (Line: 158)
Drupal::service('metatag.manager') (Line: 26)
Drupal\metatag\Form\MetatagDefaultsForm->form(Array, Object) (Line: 115)
Drupal\Core\Entity\EntityForm->buildForm(Array, Object)
call_user_func_array(Array, Array) (Line: 514)
Drupal\Core\Form\FormBuilder->retrieveForm('metatag_defaults_edit_form', Object) (Line: 271)
Drupal\Core\Form\FormBuilder->buildForm('metatag_defaults_edit_form', Object) (Line: 74)
Drupal\Core\Controller\FormController->getContentResult(Object, Object)
call_user_func_array(Array, Array) (Line: 123)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() (Line: 574)
Drupal\Core\Render\Renderer->executeInRenderContext(Object, Object) (Line: 124)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) (Line: 97)
Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}()
call_user_func_array(Object, Array) (Line: 144)
Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object, 1) (Line: 64)
Symfony\Component\HttpKernel\HttpKernel->handle(Object, 1, 1) (Line: 57)
Drupal\Core\StackMiddleware\Session->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object, 1, 1) (Line: 99)
Drupal\page_cache\StackMiddleware\PageCache->pass(Object, 1, 1) (Line: 78)
Drupal\page_cache\StackMiddleware\PageCache->handle(Object, 1, 1) (Line: 72)
Drupal\shield\ShieldMiddleware->handle(Object, 1, 1) (Line: 47)
Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object, 1, 1) (Line: 38)
Drupal\webprofiler\StackMiddleware\WebprofilerMiddleware->handle(Object, 1, 1) (Line: 50)
Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object, 1, 1) (Line: 23)
Stack\StackedHttpKernel->handle(Object, 1, 1) (Line: 656)
Drupal\Core\DrupalKernel->handle(Object) (Line: 19)

Comments

yukare created an issue. See original summary.

DamienMcKenna’s picture

Status: Active » Closed (duplicate)
Related issues: +#2882954: Error when updating to 8.x-1.1

This has already been fixed in #2882954: Error when updating to 8.x-1.1.