[D7] Viewport Alert

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectviewport_alertgit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual Review

1. Project git URL which you have posted here is incorrect. Post git URL of dev branch.
git clone --branch 7.x-1.1 git://git.drupal.org/project/viewport_alert.git

I have referred this git repo [ git clone --branch 7.x-1.x https://git.drupal.org/project/viewport_alert.git ] for below review.

2. The module readme file is not as per the Drupal recommendations. Please refer below link for module readme file template. https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...

3. function _viewport_alert_message_configure_form($form, &$form_state) is not correct way for creating config forms.
Please refer Creating the configuration form

4. Always use t() to sanitize the data.
drupal_set_message($message, 'alert-width warning');

5. Looks like there is duplicate code in viewport_alert_node_insert & viewport_alert_node_update

  $nid = $node->nid;
  $width = $node->alert;
  $message = $node->custom_message;
  if (!empty($width)) {
    db_merge('viewport_width')
      ->key(array('nid' => $nid))
      ->fields(array(
        'nid' => $nid,
        'width' => $width,
        'custom_message' => $message,
      ))
      ->execute();
  }

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.