Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.We are currently having an issue where display suite templates are not being picked up from the parent theme.
If we move these templates from the parent theme to the child profile then they are picked up and rendered correctly.
An example of the names that aren't being picked up in the child template would be,
ds-reset--node-article-teaser.html.twig
Non display suite templates are being picked up fine.
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 2895316-12.patch | 1.75 KB | anruether |
| #10 | 2895316-10.patch | 1.75 KB | gnuget |
| #3 | parent_profile_template-2895316-3.patch | 1.69 KB | GRO |
Comments
Comment #2
adamclark-dev CreditAttribution: adamclark-dev commentedComment #3
GRO CreditAttribution: GRO at Realityloop commentedPatches DS to scan templates files across the active theme and all base themes.
See Display layout twig not overridable. For some background info.
Comment #4
aspilicious CreditAttribution: aspilicious commentedI need a test for this so we don't brake it again in the future
Comment #5
realityloopComment #6
realityloopComment #7
mlncn CreditAttribution: mlncn at Agaric for Drutopia commentedMay i humbly suggest that this is a critical and subtle enough bug (subtle = damn near impossible to track down, until guessing that it's a display-suite-specific problem) that this patch be incorporated ASAP to save many many hours of sleep, and *then* the issue for a test go forward?
This patch fixes this vexing issue.
Comment #8
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedI agree that this might be extremely frustrating to track down, however, I agree with Aspilicious on this one re: tests.
I'll leave it RTBC so people can track it in the queue and know that it can be used as a patch which is valid, but won't commit it yet.
However, I'll come up with a test patch as soon as I can!
Comment #9
carma03 CreditAttribution: carma03 commented+1. Confirmed, #3 worked for me on Drupal 8.7.1 and PHP 7.3. Thanks!
Comment #10
gnugetIt seems that since #3123064: Prepare 8.x-3.x for Drupal 8.8 and 9 was merged this patch didn't apply anymore, so I rebase it.
New patch attached.
Comment #11
beunerd CreditAttribution: beunerd commented@gnuget! Can't believe I was chasing my tail all this time trying to understand why my templates weren't available in a sub-theme. Thank you!
Comment #12
anruetherWe need a small change here. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Theme%21A...
Comment #13
Abhijith S CreditAttribution: Abhijith S as a volunteer and at Zyxware Technologies commentedGot this same issue when creating a subtheme.The patch #12 fixes the issue.Thank you.
Comment #14
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedComment #15
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedI've reworked some things in 5.0.x dealing with layout etc, see https://www.drupal.org/project/ds/issues/3123311#comment-14694708
One one the things is that I simply decided to kill suggestions that DS was exposing, I couldn't get my head around it anymore or other bugs that are clearly related to the theming system. DS (layouts) now follow(s) the layout discovery module pattern re: templates etc, so any bugs should be opened against core.
I guess #2911996: Layout template suggestions are not loaded properly is related - but can't tell for sure.
Comment #16
swentel CreditAttribution: swentel at eps & kaas for Dropsolid commentedNote: I've bringing back suggestions, apparently we do use that at work a lot :)
The code in ds registry is still gone though, there are tests that at least prove that a template in another theme is picked, so I think that's covered. If there are still problems down the road, it's a core issue, likely with layout discovery or the theme system since the default theming hook now uses layout.