Problem/Motivation

ViewExecutable employs a custom serialization mechanism in ::(un|)serialize(). It fails to populate the the $viewsData and $routeProvider member variables, however, so that after serializing and unserializing a view executable, fatals can occur.

Proposed resolution

Populate the member variables properly in ViewExecutable::unserialize().

Comments

tstoeckler created an issue. See original summary.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler at bio.logis Genetic Information Management GmbH commented
Related issues: +#2849674: Complex job in ViewExecutable::unserialize() causes data corruption

Interestingly this is also fixed by #2849674: Complex job in ViewExecutable::unserialize() causes data corruption, so marking as related at least. This is a separate symptom, though, so keeping open for now.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.0-alpha1 will be released the week of January 17, 2018, which means new developments and disruptive changes should now be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.6.x-dev » 8.7.x-dev

Drupal 8.6.0-alpha1 will be released the week of July 16, 2018, which means new developments and disruptive changes should now be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.0-alpha1 will be released the week of October 14th, 2019, which means new developments and disruptive changes should now be targeted against the 8.9.x-dev branch. (Any changes to 8.9.x will also be committed to 9.0.x in preparation for Drupal 9’s release, but some changes like significant feature additions will be deferred to 9.1.x.). For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Related issues: +#2699957: routeProvider is null in ViewExecutable

@tstoeckler found this triaging an old issue that was postponed. You seemed to think this might not be fixed in that other issue, do you think it's still a bug?

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
CreditAttribution: tstoeckler commented
Status: Active » Closed (duplicate)

Hey there. It does seem to have been fixed by #2849674: Complex job in ViewExecutable::unserialize() causes data corruption like I noted in #2 so yes, I think, this can be closed as duplicate.

#2699957: routeProvider is null in ViewExecutable was also opened (and discussed) before that went in so I think that can also be closed as a duplicate of #2849674: Complex job in ViewExecutable::unserialize() causes data corruption, will do that now.

Thanks for the pointer!

pameeela’s picture

pameeela CreditAttribution: pameeela commented
Issue tags: +Bug Smash Initiative

Yay! Two in one! Thanks Tobias.