There are some coding standard and dependency issues in this module.

FILE: /root/repos/pareviewsh/pareview_temp/likeit.routing.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
7 | WARNING | The administration page callback should probably use
| | "administer site configuration" - which implies the user
| | can change something - rather than "access administration
| | pages" which is about viewing but not changing
| | configurations.
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/likeit.info.yml
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------
8 | WARNING | All dependencies must be prefixed with the project name,
| | for example "drupal:"
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Form/LikeItSettingsForm.php
--------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
--------------------------------------------------------------------------
117 | WARNING | [ ] Possible useless method overriding detected
151 | WARNING | [x] A comma should follow the last multiline array item.
| | Found: 'comment'
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/src/Entity/LikeIt.php
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
10 | WARNING | [x] Unused use statement
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /root/repos/pareviewsh/pareview_temp/likeit.links.menu.yml
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
6 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

CommentFileSizeAuthor
#7 module_dependencies_fix-2895266-7.patch317 bytesandrew_tspkh
#2 likeit_dependency_coding_standard-2895266-2.patch2.13 KBjayesh_makwana
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jayesh_makwana created an issue. See original summary.

jayesh_makwana’s picture

jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commented
FileSize
likeit_dependency_coding_standard-2895266-2.patch2.13 KB

We created a patch for solving coding standard and dependency issues for this module. Please check and apply it.

andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
CreditAttribution: andrew_tspkh commented
Status: Active » Closed (won't fix)

Hi @jayesh_makwana,
Sorry, but module doesn't have release. Module is а draft, under construction and planning. Future patches will not be applying.

andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
CreditAttribution: andrew_tspkh commented
Status: Closed (won't fix) » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
CreditAttribution: andrew_tspkh commented
Version: » 8.x-1.x-dev
Assigned: jayesh_makwana » andrew_tspkh
Status: Closed (fixed) » Active

Module dependencies need to be fixed.

andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
CreditAttribution: andrew_tspkh commented
FileSize
module_dependencies_fix-2895266-7.patch317 bytes

  • justin. committed 9906758 on 8.x-1.x 
    Issue #2895266 by justin.: Drupal Dependency and Coding standard issues
andrew_tspkh’s picture

andrew_tspkh
Primary language Ukrainian
CreditAttribution: andrew_tspkh commented
Status: Active » Fixed

Merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.