Problem/Motivation

Split from #2894822: Error: The value you selected is not a valid choice.. Field 3rd party settings are missing schema.

Proposed resolution

Add schema.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 2895045-2.patch6.33 KBclaudiu.cristea
#2 2895045-2-test-only.patch5.09 KBclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
FileSize
2895045-2-test-only.patch5.09 KB
2895045-2.patch6.33 KB

Patch & tests-only.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea as a volunteer and at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Status: Active » Needs review
pfrenssen’s picture

pfrenssen
Location Sofia
CreditAttribution: pfrenssen commented
Status: Needs review » Reviewed & tested by the community

Awesome, thanks!

+++ b/config/schema/better_formats.schema.yml
@@ -4,3 +4,36 @@ better_formats.settings:
+      sequence:
+        # Ignoring: The value can be either string or integer.
+        type: ignore

TIL that there is an 'ignore' type, very useful :)

dragonwize’s picture

dragonwize CreditAttribution: dragonwize commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

What is this new test module? This issue just says it is providing schema.

lamp5’s picture

lamp5
Primary language Polish
Location Rzeszow
CreditAttribution: lamp5 at abventor commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Test module provided sets of test to show us that schema is missing. Patch works for me.

  • mandclu committed 8cd849d3 on 8.x-1.x 
    Issue #2895045 by claudiu.cristea: Provide config schema for field 3rd...
mandclu’s picture

mandclu CreditAttribution: mandclu as a volunteer and at Acquia commented
Status: Reviewed & tested by the community » Fixed

Thanks for the work here. Merged in.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.