Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
This module sends out a notification when a particular coupon code usage count reaches to the maximum limit. This will help site administrator to monitor the coupons.
Email will be sent to the site administrator and other multiple email addresses added through the system setting form separated by comma.
Project link
https://www.drupal.org/sandbox/hiramanpatil/2759229
Git instructions
git clone --branch 7.x-1.x https://git.drupal.org/sandbox/hiramanpatil/2759229.git commerce_coupon_limit_notification
Comments
Comment #2
PA robot CreditAttribution: PA robot commentedWe are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #3
jayesh_makwana CreditAttribution: jayesh_makwana at cmsMinds commentedHello @hiramanpatil,
I checked your module, however, there are some coding issues and recommendations that you may be interested in:
FILE: ...s/pareviewsh/pareview_temp/commerce_coupon_limit_notification.module
--------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------
80 | ERROR | [x] There must be no blank lines after the function
| | comment
106 | ERROR | [x] Concat operator must be surrounded by a single space
106 | ERROR | [x] Concat operator must be surrounded by a single space
119 | ERROR | [x] There must be no blank lines after the function
| | comment
--------------------------------------------------------------------------
Thank you.
Comment #4
hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commented@jayesh_makwana, thanks for reviewing this module.
I have resolved
Concat operator must be surrounded by a single space
error from the code. The blank line error is related to the editor settings. As I checked, there is no blank line after the given line no. But I will try to resolve it.Thanks,
Comment #5
hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commentedComment #6
arunkumark@hiramanpatil
1. Functions should, in addition, have the grouping/module name as a prefix, to avoid name collisions between modules.
function _commerce_coupon_limit_notification_admin_form($form, &$form_state) {
and
function _commerce_coupon_limit_notification_admin_form_validate($form, &$form_state) {
2. The function commerce_coupon_limit_notification_mail() will affect the all mails trigger from Drupal system. So the format HTML will affects for all mails.
3. Coding standard issue
Ref: http://www.codeexpertz.com/blog/drupal/drupal-coding-standards-do-and-dont
Comment #7
hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commented@arunkumark
Thanks for reviewing this module.
1. I have the same function names as you mentioned. Do I need to change anything in function names?
2. Resolved
3. This is related to editor. Working on it.
Thanks,
Comment #8
hiramanpatil CreditAttribution: hiramanpatil at Clarion Technologies commentedComment #9
sleitner CreditAttribution: sleitner commentedAutomated Review
Pareview details: https://pareview.sh/pareview/https-git.drupal.org-project-commerce_disco...
Review of the 7.x-1.x branch (commit 37fb18b):
hook_help()
. See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .This automated report was generated with PAReview.sh, your friendly project application review script.
Manual Review
If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.
This review uses the Project Application Review Template.
Comment #10
apadernoComment #11
apadernoThank you for your contribution!
We just accept applications from users who don't have the vetted role. Any application opened after the role is given is closed settings its status to Closed (duplicate) (if a previous application exists) or Closed (won't fix).
The purpose of these applications is not reviewing every project, but give users the vetted role. Once the role is given, there is no need to apply again: These applications don't change the status of a project, but give the users the role necessary to change the status of their projects (the ones they already created or the ones they will create).