Problem/Motivation

Proposed resolution

Remaining tasks

Agree on proposed design
Create correct patch

User interface changes

Toolbar background when in edit mode will not be white anymore but use the same blue background gradient that's applied to the "Edit mode" button itself.

API changes

None

Data model changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

yoroy created an issue. See original summary.

yoroy’s picture

Status: Active » Needs review
FileSize
533 bytes
Wim Leers’s picture

This definitely feels simpler/more consistent.

I'd RTBC, but it's not my place.

tedbow’s picture

Status: Needs review » Needs work
FileSize
26.05 KB

I think this looks good.

The only 2 thoughts I have

We should change the Place Block to be white in edit mode. Otherwise it doesn't stand out. I think this needs a fix.

If we have multiple toolbar items in the edit mode, later added by core or contrib and they are all white then the "Editing" button no longer stands out. This just an observation. Maybe it is fine.

xjm’s picture

Yes, the white is very distracting and it looks like a bug. The all-blue would be an improvement.

Wim Leers’s picture

Title: White toolbar background when in edit mode is distrating and not pretty » White toolbar background when in edit mode is distracting and not pretty
Status: Needs work » Needs review

#4: I think this is something that block_place.module has to solve. There's zero Place Block-specific styles in the Settings Tray module today, and I don't think we want to change that.

tedbow’s picture

@Wim Leers sure block_place.module but we should least have a follow up for that module. Since the CSS for that link work fine right now but won't after this issue is committed

Wim Leers’s picture

tedbow’s picture

Status: Needs review » Reviewed & tested by the community

@Wim Leers great thanks! RTBC!

Wim Leers’s picture

  • xjm committed 1637731 on 8.4.x
    Issue #2894427 by yoroy, tedbow, Wim Leers: White toolbar background...

  • xjm committed f7f46f7 on 8.3.x
    Issue #2894427 by yoroy, tedbow, Wim Leers: White toolbar background...
xjm’s picture

Version: 8.4.x-dev » 8.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committing eagerly. This looks so much better and resolves something that I raised in my initial reviews. I tested various togglings of Edit mode, cursor hovering, etc. with the patch and everything looked keen.

Committed to 8.4.x. I also backported it to 8.3.x as an improvement to an experimental module.

Thanks @yoroy for proposing this patch!

tedbow’s picture

@yoroy @xjm @Wim Leers thanks for work on this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)