Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
Proposed resolution
Remaining tasks
Agree on proposed design
Create correct patch
User interface changes
Toolbar background when in edit mode will not be white anymore but use the same blue background gradient that's applied to the "Edit mode" button itself.
API changes
None
Data model changes
None
Comment | File | Size | Author |
---|---|---|---|
#4 | blue_with_place_block.png | 26.05 KB | tedbow |
#2 | 2894427-2.patch | 533 bytes | yoroy |
edit-mode-toolbar-fill.png | 96.61 KB | yoroy | |
editing-mode-white-toolbar.png | 143.86 KB | yoroy |
Comments
Comment #2
yoroy CreditAttribution: yoroy at Roy Scholten commentedComment #3
Wim LeersThis definitely feels simpler/more consistent.
I'd RTBC, but it's not my place.
Comment #4
tedbowI think this looks good.
The only 2 thoughts I have
We should change the Place Block to be white in edit mode. Otherwise it doesn't stand out. I think this needs a fix.
If we have multiple toolbar items in the edit mode, later added by core or contrib and they are all white then the "Editing" button no longer stands out. This just an observation. Maybe it is fine.
Comment #5
xjmYes, the white is very distracting and it looks like a bug. The all-blue would be an improvement.
Comment #6
Wim Leers#4: I think this is something that
block_place.module
has to solve. There's zero Place Block-specific styles in the Settings Tray module today, and I don't think we want to change that.Comment #7
tedbow@Wim Leers sure
block_place.module
but we should least have a follow up for that module. Since the CSS for that link work fine right now but won't after this issue is committedComment #8
Wim LeersFollow-up created: #2897252: Improve styling of "Place Block" toolbar tab while Settings Tray's edit mode is active.
Comment #9
tedbow@Wim Leers great thanks! RTBC!
Comment #10
Wim LeersThe follow-up for Place Block is already pre-RTBC'd: #2897252-4: Improve styling of "Place Block" toolbar tab while Settings Tray's edit mode is active.
Comment #13
xjmCommitting eagerly. This looks so much better and resolves something that I raised in my initial reviews. I tested various togglings of Edit mode, cursor hovering, etc. with the patch and everything looked keen.
Committed to 8.4.x. I also backported it to 8.3.x as an improvement to an experimental module.
Thanks @yoroy for proposing this patch!
Comment #14
tedbow@yoroy @xjm @Wim Leers thanks for work on this!
Comment #16
tedbowChanging to new settings_tray.module component. @drpal thanks for script help! :)