Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
Adding a currency vs a custom currency is unclear for the user.
There are two buttons when in Commerce:Configuration:Currencies
Proposed resolution
1. Add Currency
2. Import Currencies
Expected:
As a standard user, my first impulse would be to add a pre-configured currency. When I view this page, I want to click on "Add Currency" and expect a simple interface to select the currency ie. USD, CAD.
Actual:
When I click on Add Currency, I am taken to a new page where I have to create a Custom Currency, but it is not clearly labeled that this is what I am doing. What the user actually needs to do is to click on "Import Currencies" and get taken to the list of pre-configured currencies.
Solution:
Since as a user, I would expect the simpler, quicker, pre-configured option to be the default, I would want the following:
1. Rename the buttons in the following way:
+Add Currency => +Add Custom Currency
+Import Currencies => +Add Currency
We would the want to order the new "+Add Currency" button on the left, and the "+Add Custom Currency" button on the right as the user would be drawn to consider the first item in the line as the default, more commonly clicked item.
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | commerce-pricing-ux-2893967-6.patch | 1.94 KB | cbildstein |
| #6 | commerce-currency-ux-button-preview.png | 29.83 KB | cbildstein |
Comments
Comment #2
bojanz CreditAttribution: bojanz at Centarro commentedMakes sense.
Comment #3
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedComment #4
AaronChristian CreditAttribution: AaronChristian at Acro Commerce commentedAlso consider only using 1 primary button (+ Add Currency), and a secondary style for the custom currency button (+ Add Custom Currency).
Comment #5
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedYeah that's what I was thinking. Not good having both options as a primary action for the user.
Comment #6
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedUpdated the links with:
I looked into the primary vs. secondary button style and there's a few ways to go about it.
Fix 'button--primary' in Seven theme: The action links are just links, but if you're using the Seven admin theme, the 'button--primary' class gets added to all of the links. This is really an issue with the Seven theme, as not every single link should be given that style, only the first link in the list. That way, 'button' would be on all links, but 'button--primary' would only be on the first link so then the UX wouldn't be so bad. Attached 'commerce-currency-ux-button-preview.png' on what it would look like.
Or, could use a preprocess_menu_local_action and theme_registry_alter to preprocess the links after the Seven theme, and remove that primary style from getting added to every button in the list. Not a huge fan of this method as it's pretty theme specific, even if it is a common theme.
Or, make a custom set of styles within the Commerce module and use that for all action links so they are consistent within the module and have primary/secondary button styles.
Comment #7
cbildstein CreditAttribution: cbildstein at Acro Commerce commentedComment #8
rszrama CreditAttribution: rszrama at Centarro commentedWe can probably clarify this even further... change it from "Add custom currency" to "Define custom currency." No accidental confusion over "Add" then. I do agree with reordering the buttons to make the common action the first one.
Comment #9
bojanz CreditAttribution: bojanz at Centarro commentedI like the current direction. I think we should postpone the "Define" language to another issue, I'm wary of introducing it for this screen only when no other screen in Drupal or Commerce uses it.
Problems that we currently have with this patch:
1) The "Add currency" screen has an "Import" submit button, which is odd. We can at least rename that to "Save".
2) Clicking "Add custom currency" leads to a screen titled "Add currency", we need to override the title for entity.commerce_currency.add_form
3) Our urls no longer match the titles. Should we rename /import to /add and /add to /add-custom?
Comment #10
bojanz CreditAttribution: bojanz at Centarro commentedRetitling. #3 approved by Ryan and Matt.
We can also remove the warning message from the "Add custom currency" form.
Comment #12
bojanz CreditAttribution: bojanz at Centarro commentedDone. Thank you, Acro team!