Cannot unset "Group creator must complete their membership" [#2893774]

Problem/Motivation

I noticed that I cannot unset "Group creator must complete their membership" option in /admin/group/types/manage/{group-type}

animation of failing to unset value

Proposed resolution

It looks like the GroupType config entity had the property defined in such a way that is is ALWAYS set to TRUE. It simply won't be possible to unset the value!

From 8.x-dev:

  /**
   * The group creator must immediately complete their membership.
   *
   * @var bool
   */
  protected $creator_wizard = TRUE;

Same applies to the $creator_membership property.

I believe we should not set a value here.

Remaining tasks

~~patch~~
review

User interface changes

none

Comment	File	Size	Author
#2	cannot_unset_group-2893774-2.patch	607 bytes	rachel_norfolk
#2	8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 55 pass, 2 fail
	must-run-creator-wizard.gif	7.72 MB	rachel_norfolk

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

11 July 2017 at 10:10

rachel_norfolk created an issue. See original summary.

Comment #2

rachel_norfolk

English

CreditAttribution: rachel_norfolk at Open Development Ltd commented 11 July 2017 at 10:18

Issue summary:

View changes

File	Size
cannot_unset_group-2893774-2.patch	607 bytes
8.x-1.x: PHP 5.5 & MySQL 5.5, D8.4 55 pass, 2 fail

1 file was hidden/shown/deleted

File	Size
must-run-creator-wizard.gif	7.72 MB

A little patch...

Comment #3

rachel_norfolk

English

CreditAttribution: rachel_norfolk at Open Development Ltd commented 11 July 2017 at 10:19

Status:

Active

» Needs review

remembering to set the issue status AFTER submitting a patch for the millionth time! :oops:

Comment #4

maaty388 CreditAttribution: maaty388 commented 28 August 2017 at 11:55

Status:

Needs review

» Reviewed & tested by the community

Yeah it works

Comment #5

kristiaanvandeneynde

Dutch

Antwerp, Belgium

CreditAttribution: kristiaanvandeneynde at Deeson commented 4 September 2017 at 12:21

Status:

Reviewed & tested by the community

» Needs work

Hmm, the properties this patch changes have values because those should act as default values. GroupTypeForm should allow you to unset them, which it does on my machine and on simplytest.me.

So what do you have on your machine that a clean install doesn't? :)