[D7] PBS Media Manager [#2893613]

The Media Manager API allows stations, producers, and viewers of PBS.org to search and view digital assets. This module is not officially affiliated with, or maintained by, PBS. This is a replacement for the existing PBS Cove API and PBS COVE API Player modules as that API is now deprecated.

This new module includes four submodules:

PBS Media Manager API Test Interface: Allows admins to run queries against the API to see what comes back.
PBS Media Manager Show: Provides Media Manager shows as Drupal entities. (Requires Views and Entity API)
PBS Media Manager Player: Provides a field to embed PBS partner players through the Media Manager API.
PBS Media Manager Migrate: Provides a mechanism to migrate COVE API Player fields to Media Manager Player fields. (Requires COVE API Player version 7.x-1.1 or higher

Use of this module requires an API key, which can be requested from PBS.

Project Page:

https://www.drupal.org/project/pbs_media_manager

Git Command:

git clone --branch 7.x-1.x https://git.drupal.org/project/pbs_media_manager.git

Past Application Review:

By acrosman:
https://www.drupal.org/node/2601994

By jesss:
https://www.drupal.org/node/2601994
https://www.drupal.org/node/2597211
https://www.drupal.org/node/2884065

Comments

Comment #1

10 July 2017 at 18:48

acrosman created an issue. See original summary.

Comment #2

acrosman

English

South Carolina, US

CreditAttribution: acrosman at Cyberwoven commented 10 July 2017 at 18:50

Issue summary:

View changes

Comment #3

PA robot CreditAttribution: PA robot commented 10 July 2017 at 22:23

Status:

Needs review

» Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpsgitdrupalorgprojectpbs_media_managergit

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #4

PA robot CreditAttribution: PA robot commented 31 July 2017 at 22:25

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #5

jesss CreditAttribution: jesss commented 10 August 2017 at 19:51

Status:

Closed (won't fix)

» Needs review

All of the errors and warnings generated by the automated review that can be fixed, have been fixed.

The remaining errors all refer to methods and properties not being in the proper camel format. All but one of these are in PBSMediaManagerAPIClient.php. This is a shared client that is being used in production on both Wordpress and Drupal sites -- changing the format of those methods and properties would cause significant hardship.

The final error refers to a views handler not being in the proper camel format. Since that is extending an existing views handler, I don't believe it can be changed.

Comment #6

jesss CreditAttribution: jesss commented 11 August 2017 at 21:46

And this project now also has a stable release.

Comment #7

jesss CreditAttribution: jesss commented 12 August 2017 at 17:59

Issue summary:	View changes
Issue tags:		+PAreview: review bonus

Comment #8

jesss CreditAttribution: jesss commented 14 August 2017 at 20:54

The automated review now comes back clean.

Comment #9

sleitner CreditAttribution: sleitner commented 20 July 2018 at 20:51

Status:

Needs review

» Needs work

Automated Review

pareview details see: https://pareview.sh/pareview/https-git.drupal.org-project-pbs_media_mana...

Review of the 7.x-2.x branch (commit e27e4fc):

Your README.md does not follow best practices (headings need to be uppercase). See https://www.drupal.org/node/2181737 .
./modules/pbs_media_manager_migrate/pbs_media_manager_migrate.inc: All functions should be prefixed with your module/theme name (pbs_media_manager_migrate) to avoid name clashes. See https://www.drupal.org/node/318#naming
./modules/pbs_media_manager_api_ui/pbs_media_manager_api_ui.module: All functions should be prefixed with your module/theme name (pbs_media_manager_api_ui) to avoid name clashes. See https://www.drupal.org/node/318#naming
The pbs_media_manager.module does not implement hook_help(). See https://www.drupal.org/docs/develop/documenting-your-project/module-docu... .
Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
No automated test cases were found, did you consider writing Simpletests or PHPUnit tests? This is not a requirement but encouraged for professional software development.

This automated report was generated with PAReview.sh, your friendly project application review script.

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts. Which user wants to opt into security advisory coverage? @acrosman or @jesss ?
No duplication: Yes: Does not cause module duplication and/or fragmentation.
Master Branch: Yes: Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: Yes: Follows the guidelines for 3rd party assets/code.
README.txt/README.md: No: Does not follow the guidelines for in-project documentation and/or the README Template. See pareview details
Code long/complex enough for review: Yes: Follows the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements.
Coding style & Drupal API usage: See pareview details
The starred items (*) are fairly big issues and warrant going back to Needs Work. Items marked with a plus sign (+) are important and should be addressed before a stable project release. The rest of the comments in the code walkthrough are recommendations.

If added, please don't remove the security tag, we keep that for statistics and to show examples of security problems.

This review uses the Project Application Review Template.

Comment #10

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 22 October 2018 at 06:50

Status:

Needs work

» Closed (won't fix)

If you are still interested on being able to opt into security coverage for projects you create, please open a new application using a project for which the only commits (for the time required to set the application's status to Fixed) are from you.
Please don't open a new application if you aren't sure to have time to dedicate to the application, or it will be closed again as won't fix.

I am closing this application due to lack of activity.