Problem/Motivation

I think I've run into trouble with JS preprocessing / aggregation with the current theme_google_store_locator_contents().
As soon as I enable the preprocessing the store locator ceases to work.
As far as I can tell this is related the weight/grouping of the attached javascript files.

Proposed resolution

I think the google map and store locator libraries should be declared as libraries using the group option.

Remaining tasks

Reviews needed.

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 google_store_locator-set-js-group-2893368-2.patch1.35 KBdas-peter
google_store_locator-set-js-group.patch1.32 KBdas-peter
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

das-peter created an issue. See original summary.

das-peter’s picture

das-peter CreditAttribution: das-peter at Cando commented
FileSize
google_store_locator-set-js-group-2893368-2.patch1.35 KB

Added weight to the store-locator files in order to come after the google maps API.
Fixed parenthesis in store-locator.compiled.js code.

rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Status: Needs review » Reviewed & tested by the community

Thanks @das-peter
I committed the changed in the dev branch

  • rodrigoeg committed 49e2ed6 on 7.x-1.x authored by das-peter 
    Issue #2893368 by das-peter, rodrigoeg: Set weight / group for JS...
rodrigoeg’s picture

rodrigoeg CreditAttribution: rodrigoeg at CI&T commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.