Target option as select field

I'd support this if it could be done in a way that didn't introduce a switch or else statement.

So it would probably require moving the attributes to plugins.

Ideally we could do this without changing the data structure.

So that would require the plugin IDs matching the attribute names.

Thanks

FWIW I would support yaml based discovery for this

A base class would handle most cases.

This is looking great, really simple.

Adding tag to update documentation.

1. +++ b/src/LinkAttributesManager.php
   @@ -0,0 +1,67 @@
   +  protected $defaults = array(
   +    'title' => '',
   +    'type' => '',
   +    'description' => '',
   +  );
   

   can we short syntax here, thanks

2. +++ b/src/LinkAttributesManager.php
   @@ -0,0 +1,67 @@
   +    // Add more services as required.
   

   Please remove this - console cruft?

3. +++ b/src/LinkAttributesManager.php
   @@ -0,0 +1,67 @@
   +    // Make sure each plugin definition had at least a field type.
   +    if (empty($definition['type'])) {
   +      throw new PluginException(sprintf('Link attribute plugin property (%s) definition is required.', $plugin_id));
   +    }
   

   If its missing, lets default to 'textfield' and then remove the 'textfield' from the yml file, so we only have to nominate type if its out of the ordinary, less verbose

4. +++ b/src/Plugin/Field/FieldWidget/LinkWithAttributesWidget.php
   @@ -55,13 +55,15 @@ class LinkWithAttributesWidget extends LinkWidget {
   +    $plugin_definitions = \Drupal::service('plugin.manager.link_attributes')->getDefinitions();
   
   @@ -71,12 +73,16 @@ class LinkWithAttributesWidget extends LinkWidget {
   +    $plugin_definitions = \Drupal::service('plugin.manager.link_attributes')->getDefinitions();
   

   Please implement ContainerFactoryPluginInterface for the widget and inject

5. +++ b/src/Plugin/Field/FieldWidget/LinkWithAttributesWidget.php
   @@ -55,13 +55,15 @@ class LinkWithAttributesWidget extends LinkWidget {
   +        $default_value = isset($attributes[$attribute]) ? $attributes[$attribute] : '';
   +        $element['options']['attributes'][$attribute]['#default_value'] = $default_value;
   

   Nit: let's drop the local variable, not used elsewhere

6. +++ b/src/Plugin/Field/FieldWidget/LinkWithAttributesWidget.php
   @@ -71,12 +73,16 @@ class LinkWithAttributesWidget extends LinkWidget {
   +    foreach ($plugin_definitions as $plugin_id => $plugin_definition) {
   +      $options[$plugin_id] = $plugin_definition['title'];
   +    }
   

   Can you use array_map here and avoid the foreach, the keys are the same.

Thanks again, great work

1. +++ b/src/Plugin/Field/FieldWidget/LinkWithAttributesWidget.php
   @@ -17,7 +21,49 @@ use Drupal\link\Plugin\Field\FieldWidget\LinkWidget;
   +  private $linkAttributesManager;
   

   Nit, private => protected, we don't really use private much in Drupal - can be fixed on commit

2. +++ b/src/Plugin/Field/FieldWidget/LinkWithAttributesWidget.php
   @@ -55,14 +101,13 @@ class LinkWithAttributesWidget extends LinkWidget {
   +        $element['options']['attributes'][$attribute]['#default_value'] = isset($attributes[$attribute]) ? $attributes[$attribute] : '';
          }
   

   oh for php7 and null coalesce :)

Thanks again

Fixed, thanks

Rolling a 1.1 release and updating docs